Skip to content

Translates Invalid hook call warning - #52

Merged
glaucia86 merged 8 commits into
reactjs:masterfrom
henriquejensen:invalid-hook-call-warning
Feb 14, 2019
Merged

Translates Invalid hook call warning#52
glaucia86 merged 8 commits into
reactjs:masterfrom
henriquejensen:invalid-hook-call-warning

Conversation

@henriquejensen

@henriquejensenhenriquejensen commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@fjoshuajrfjoshuajr added the needs review A pull request ready to be reviewed label Feb 9, 2019
jhonmike
jhonmike previously approved these changes Feb 10, 2019
View reviewed changes
glaucia86
glaucia86 suggested changes Feb 10, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henriquejensen
Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
@glaucia86glaucia86 added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
@glaucia86

glaucia86 commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

@henriquejensen
Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

@henriquejensen

henriquejensen commented Feb 10, 2019

Copy link
Copy Markdown
ContributorAuthor

@glaucia86 acabei fazendo um merge com a master antes das alterações, não sei se foi o correto, qualquer coisa eu repito o pull request

@eduardomoronieduardomoroni added needs +1 Needs another approval before merging feedback addressed and removed needs author response Changes requested needing author's input labels Feb 12, 2019
@fjoshuajrfjoshuajr added needs author response Changes requested needing author's input and removed feedback addressed needs +1 Needs another approval before merging labels Feb 12, 2019
@fjoshuajr

fjoshuajr commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

@henriquejensen volte a fazer um novo PR 😉, esse tem muitos ficheiros.

@fjoshuajrfjoshuajr added the invalid Something that is outside the scope label Feb 12, 2019
@cezaraugusto
cezaraugustoforce-pushed the invalid-hook-call-warning branch from 780d987 to 38af765CompareFebruary 13, 2019 04:26
@cezaraugusto

cezaraugusto commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

@henriquejensen obrigado por tirar um tempinho pra fazer essas alteracoes! fiz um rebase do seu branch pra ajudar os revisores.

@fjoshuajr pode conferir de novo? vou remover a tag invalid

@cezaraugustocezaraugusto added feedback addressed and removed invalid Something that is outside the scope needs author response Changes requested needing author's input labels Feb 13, 2019
fjoshuajr
fjoshuajr suggested changes Feb 13, 2019
View reviewed changes

@fjoshuajrfjoshuajr left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henriquejensen estamos quase lá 💪

Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
@fjoshuajrfjoshuajr added needs author response Changes requested needing author's input and removed feedback addressed labels Feb 13, 2019
@henriquejensen

henriquejensen commented Feb 14, 2019

Copy link
Copy Markdown
ContributorAuthor

Hey @fjoshuajr acabei de realizar o commit com as alterações que voce solicitou

fjoshuajr
fjoshuajr approved these changes Feb 14, 2019
View reviewed changes

@fjoshuajrfjoshuajr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉✨

@fjoshuajrfjoshuajr added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 14, 2019
@glaucia86
glaucia86 merged commit cd23555 into reactjs:masterFeb 14, 2019
@tesseralistesseralis mentioned this pull request Feb 14, 2019
Closed
90 tasks
@glaucia86glaucia86 removed the needs +1 Needs another approval before merging label Feb 14, 2019
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@henriquejensen@glaucia86
Translates Invalid hook call warning (reactjs#52)
36bda8a
* Translates invalid-hook-call-warning to pt-BR
* Code Review feecback
* Translates invalid-hook-call-warning to pt-BR
* Code Review feecback
* Feedback Review from fjoshuajr
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhonmikejhonmikejhonmike left review comments
+2 more reviewers
@glaucia86glaucia86glaucia86 approved these changes
@fjoshuajrfjoshuajrfjoshuajr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@glaucia86glaucia86

@fjoshuajrfjoshuajr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@henriquejensen@glaucia86@fjoshuajr@cezaraugusto@jhonmike@eduardomoroni