Skip to content

Translate Hello World - #57

Merged
glaucia86 merged 11 commits into
reactjs:masterfrom
rafael-vitor:hello-world
Feb 12, 2019
Merged

Translate Hello World#57
glaucia86 merged 11 commits into
reactjs:masterfrom
rafael-vitor:hello-world

Conversation

@rafael-vitor

@rafael-vitorrafael-vitor commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

@fjoshuajrfjoshuajr added the needs review A pull request ready to be reviewed label Feb 10, 2019
tibuurcio
tibuurcio suggested changes Feb 10, 2019
View reviewed changes

@tibuurciotibuurcio left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rafael-vitor, thanks for taking the time to help with translation. The hello-world page is such an important one!

I've made some reviews mostly based on syntax. Also, we shouldn't translate anchor links as per the universal styleguide.

Please let me know if you think anything should be different. Cheers 😄

Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
@tibuurciotibuurcio added the needs author response Changes requested needing author's input label Feb 10, 2019
glaucia86
glaucia86 suggested changes Feb 10, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafael-vitor

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
Comment threadcontent/docs/hello-world.md Outdated
@glaucia86glaucia86 removed the needs review A pull request ready to be reviewed label Feb 10, 2019
@glaucia86

glaucia86 commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

@rafael-vitor

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

tibuurcioand others added 10 commits February 10, 2019 11:30
@tibuurcio@rafael-vitor
Update content/docs/hello-world.md
2cbc076
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@tibuurcio@rafael-vitor
Update content/docs/hello-world.md
c23fe78
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@tibuurcio@rafael-vitor
Update content/docs/hello-world.md
be484a1
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@tibuurcio@rafael-vitor
Update content/docs/hello-world.md
43bd21c
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@tibuurcio@rafael-vitor
Update content/docs/hello-world.md
2b44323
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@glaucia86@rafael-vitor
Update content/docs/hello-world.md
d2e6408
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@glaucia86@rafael-vitor
Update content/docs/hello-world.md
c97691a
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@glaucia86@rafael-vitor
Apply suggestions from code review
57afdd4
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
@rafael-vitor
FIx duplicated line
cadb27f
@rafael-vitor
Add missing >
297eaf9
@rafael-vitor

rafael-vitor commented Feb 10, 2019

Copy link
Copy Markdown
ContributorAuthor

Olá @glaucia86

As alterações solicitadas foram realizadas.

@tesseralistesseralis mentioned this pull request Feb 10, 2019
Closed
90 tasks
@rafael-vitor

rafael-vitor commented Feb 11, 2019

Copy link
Copy Markdown
ContributorAuthor

@glaucia86 Acho que não posso alterar a label por que não sou contribuidor 😬

@tibuurciotibuurcio added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
glaucia86
glaucia86 approved these changes Feb 12, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafael-vitor
LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86
glaucia86 merged commit 1cafa29 into reactjs:masterFeb 12, 2019
@glaucia86glaucia86 added 🌐 translated Translation is completed for this page and removed feedback addressed labels Feb 12, 2019
@rafael-vitor
rafael-vitor deleted the hello-world branch February 12, 2019 10:31
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@rafael-vitor@glaucia86
Translate Hello World (reactjs#57)
bbadcbd
* Hello world page translation
* Update content/docs/hello-world.md
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
* Update content/docs/hello-world.md
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
* Update content/docs/hello-world.md
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
* Update content/docs/hello-world.md
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
* Update content/docs/hello-world.md
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
* Update content/docs/hello-world.md
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
* Update content/docs/hello-world.md
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
* Apply suggestions from code review
Co-Authored-By: rafael-vitor <rafael.vitor@jusbrasil.com.br>
* FIx duplicated line
* Add missing >
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@glaucia86glaucia86glaucia86 approved these changes
@tibuurciotibuurciotibuurcio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rafael-vitor@glaucia86@tibuurcio@fjoshuajr