Skip to content

Translate Design Principles - #60

Merged
halian-vilela merged 6 commits into
reactjs:masterfrom
moiseshilario:translate-design-principles
Feb 18, 2019
Merged

Translate Design Principles#60
halian-vilela merged 6 commits into
reactjs:masterfrom
moiseshilario:translate-design-principles

Conversation

@moiseshilario

@moiseshilariomoiseshilario commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

This PR references issue #1 translating the Design Principle doc

@fjoshuajrfjoshuajr added the needs review A pull request ready to be reviewed label Feb 10, 2019
converge
converge suggested changes Feb 10, 2019
View reviewed changes
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
glaucia86
glaucia86 suggested changes Feb 10, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moiseshilario
Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
@glaucia86glaucia86 added needs +1 Needs another approval before merging needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed needs +1 Needs another approval before merging labels Feb 10, 2019
glaucia86and others added 2 commits February 11, 2019 17:42
@glaucia86@moiseshilario
Apply suggestions from code review
9ae605f
Co-Authored-By: moiseshilario <moiseshilariu@gmail.com>
@moiseshilario
Apply translations suggestions
5935dc7
@moiseshilario

moiseshilario commented Feb 11, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@glaucia86@converge Obrigado pelas sugestões e correções, a maioria delas foram aplicadas e o PR foi atualizado. Repondi alguns dos comentários, pois precisamos entrar em acordo com alguns termos. Fora isso, tudo certo para um Review de novo.

@eduardomoronieduardomoroni added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 12, 2019
@cezaraugustocezaraugusto self-assigned this Feb 14, 2019
glaucia86
glaucia86 previously approved these changes Feb 14, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moiseshilario

LGTM 👍
Muito obrigada pela sua contribuição!

@glaucia86glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed 💪 long page - more than 100 lines Long page labels Feb 14, 2019
glaucia86
glaucia86 previously approved these changes Feb 14, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moiseshilario

LGTM 👍

Muito obrigada pela sua contribuição. :)

cc: @fjoshuajr@cezaraugusto@eduardomoroni só aprovar. Mais do que revisado.

@halian-vilela
halian-vilela self-requested a review February 15, 2019 00:04
halian-vilela
halian-vilela suggested changes Feb 15, 2019
View reviewed changes

@halian-vilelahalian-vilela left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blz! Solicitei algumas pequenas modificações de detalhes que melhorariam a compreensão.

Por favor, revise e faça suas consideraçõe, se necessário, e logo sua contribuição será aprovada!

Obrigado!

Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
@halian-vilelahalian-vilela added needs author response Changes requested needing author's input and removed needs +1 Needs another approval before merging labels Feb 15, 2019
@halian-vilela@moiseshilario
Apply halian's suggestions from code review
6be8e95
Co-Authored-By: moiseshilario <moiseshilariu@gmail.com>
@moiseshilario
moiseshilario dismissed stale reviews from glaucia86 via 6be8e95February 18, 2019 14:01
@moiseshilario

moiseshilario commented Feb 18, 2019

Copy link
Copy Markdown
ContributorAuthor

@halian-vilela Muito obrigado pelas correções! PR foi corrigido e atualizado. Esperando review e aprovação.

@halian-vilela
halian-vilela merged commit 94c077a into reactjs:masterFeb 18, 2019
@halian-vilelahalian-vilela added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels Feb 18, 2019
@tesseralistesseralis mentioned this pull request Feb 18, 2019
Closed
90 tasks
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@moiseshilario@halian-vilela
Translate Design Principles (reactjs#60)
0eaed30
@moiseshilario Ótimo! Como os outros revisores já haviam aprovado, estou fazendo o merge! Obrigado pela contribuição! CC: @glaucia86@converge
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@convergeconvergeconverge requested changes
@halian-vilelahalian-vilelahalian-vilela approved these changes
@glaucia86glaucia86glaucia86 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@halian-vilelahalian-vilela

@glaucia86glaucia86

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@moiseshilario@converge@halian-vilela@glaucia86@eduardomoroni@cezaraugusto@fjoshuajr