Skip to content

Translation Lists and Keys page - #7

Merged
fjoshuajr merged 15 commits into
reactjs:masterfrom
WendellAdriel:lists-and-keys
Feb 9, 2019
Merged

Translation Lists and Keys page#7
fjoshuajr merged 15 commits into
reactjs:masterfrom
WendellAdriel:lists-and-keys

Conversation

@WendellAdriel

Copy link
Copy Markdown
Contributor

@glaucia86glaucia86 added the needs review A pull request ready to be reviewed label Feb 8, 2019
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few changes to make it.

cc: @WendellAdriel@fjoshuajr

@chmieleskichmieleski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should take a look at this suggestions.

Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated

@fjoshuajrfjoshuajr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments regarding some changes.

glaucia86and others added 6 commits February 8, 2019 14:20
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
glaucia86and others added 3 commits February 8, 2019 14:27
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
@WendellAdriel

Copy link
Copy Markdown
ContributorAuthor

Hey everyone, I made some changes, if you can please review it again!!! 😉

@fjoshuajrfjoshuajr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there @WendellAdriel

Comment threadcontent/docs/lists-and-keys.md Outdated
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
fjoshuajr
fjoshuajr previously approved these changes Feb 8, 2019

@fjoshuajrfjoshuajr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good to me! ✨

Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated
Comment threadcontent/docs/lists-and-keys.md Outdated

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @WendellAdriel eu coloquei como 'request changes' devido ao link dos títulos. Acho que tem que ser também traduzidos. Pois na hora que o usuário for clicar no nos títulos, não conseguirá até o local indicado.

O que você também @fjoshuajr ?

@fjoshuajr

fjoshuajr commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

@glaucia86 Os links que aparecem junto aos títulos não podem ser traduzidos.

EDIT: Cometi um erro, os links podem ser traduzidos sim.

Comment threadcontent/docs/lists-and-keys.md
Comment threadcontent/docs/lists-and-keys.md Outdated
@cezaraugustocezaraugusto added needs resolution Something not defined that needs maintainers input and removed needs review A pull request ready to be reviewed labels Feb 8, 2019
Comment threadcontent/docs/lists-and-keys.md
@fjoshuajr

Copy link
Copy Markdown
Contributor

Resolved the comments. Solid translation here.
I'll go ahead and merge this.

cc: @glaucia86

@fjoshuajr
fjoshuajr merged commit 69af38c into reactjs:masterFeb 9, 2019
@fjoshuajrfjoshuajr added 🌐 translated Translation is completed for this page and removed needs resolution Something not defined that needs maintainers input labels Feb 9, 2019
@tesseralistesseralis mentioned this pull request Feb 9, 2019
90 tasks
@fjoshuajrfjoshuajr changed the title Lists and Keys page translationTranslation Lists and Keys pageFeb 10, 2019
fjoshuajr pushed a commit that referenced this pull request Feb 10, 2019
* Fix links in lists-and-keys page #7
* Fix links in faq-ajax page #9
* Fix links in faq-build page #12
* Fix links in web-components page #27
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
* translated Lists and Keys page
* translated nav title for the Lists and Keys section
* Update to fix/improve the translation
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
* Update to fix/improve the translation
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
* Update to fix/improve the translation
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
* Update to fix/improve the translation
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
* Update to fix/improve the translation
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
* Update to fix/improve the translation
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
* Update to fix/improve the translation
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
* Update to fix/improve the translation
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
* Fixed and improved the translation, following the suggestions on the PR
* Update content/docs/lists-and-keys.md
Co-Authored-By: WendellAdriel <wendelladriel.ti@gmail.com>
* Update lists-and-keys.md
* Update lists-and-keys.md
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
* Fix links in lists-and-keys page reactjs#7
* Fix links in faq-ajax page reactjs#9
* Fix links in faq-build page reactjs#12
* Fix links in web-components page reactjs#27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@WendellAdriel@fjoshuajr@halian-vilela@glaucia86@cezaraugusto@lucasdeassis@chmieleski