Skip to content

Translation of the "JS Environment Requirements " page - #8

Merged
glaucia86 merged 4 commits into
reactjs:masterfrom
chmieleski:master
Feb 8, 2019
Merged

Translation of the "JS Environment Requirements " page#8
glaucia86 merged 4 commits into
reactjs:masterfrom
chmieleski:master

Conversation

@chmieleski

@chmieleskichmieleski commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

@chmieleskichmieleski changed the title Translation of the "* S Environment Requirements " pageTranslation of the "JS Environment Requirements " pageFeb 8, 2019
@glaucia86glaucia86 added the needs review A pull request ready to be reviewed label Feb 8, 2019
glaucia86
glaucia86 reviewed Feb 8, 2019
View reviewed changes
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
glaucia86
glaucia86 reviewed Feb 8, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes to make it

cc: @koka0012

@glaucia86glaucia86 added work in progress Author opened the pull-request but it's still being worked on needs review A pull request ready to be reviewed and removed needs review A pull request ready to be reviewed work in progress Author opened the pull-request but it's still being worked on labels Feb 8, 2019
glaucia86
glaucia86 suggested changes Feb 8, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes to make it

cc: @koka0012

@chmieleski

chmieleski commented Feb 8, 2019

Copy link
Copy Markdown
ContributorAuthor

Changes made @glaucia86

cezaraugusto
cezaraugusto suggested changes Feb 8, 2019
View reviewed changes

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments left. translation looks great overall but found some phrases weird to read in Portuguese so I adapted some. nice work!

Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
chmieleski
chmieleski commented Feb 8, 2019
View reviewed changes

@chmieleskichmieleski left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already changed

Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
jhonmike
jhonmike reviewed Feb 8, 2019
View reviewed changes
Comment threadcontent/docs/reference-javascript-environment-requirements.md

ReactDOM.render(
<h1>Hello, world!</h1>,
<h1>Olá, mundo!</h1>,

@jhonmikejhonmikeFeb 8, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glossary and Style Guide

...

  • Leave code blocks untranslated. (It is usually OK to translate comments inside them.)

@cezaraugustocezaraugustoFeb 8, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the input. I think for this case specifically it's ok to translate strings inside HTML/JSX elements as it doesn't change any structure/logic. I'll update the glossary

cezaraugusto
cezaraugusto approved these changes Feb 8, 2019
View reviewed changes

@cezaraugustocezaraugusto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koka0012 thanks for the quick follow-up. ++

Comment threadcontent/docs/reference-javascript-environment-requirements.md

ReactDOM.render(
<h1>Hello, world!</h1>,
<h1>Olá, mundo!</h1>,

@cezaraugustocezaraugustoFeb 8, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the input. I think for this case specifically it's ok to translate strings inside HTML/JSX elements as it doesn't change any structure/logic. I'll update the glossary

@glaucia86
glaucia86 merged commit 71b7ac1 into reactjs:masterFeb 8, 2019
@cezaraugusto

cezaraugusto commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

cc @glaucia86 I guess all feedback was addressed please merge if it looks ok to you

@glaucia86

glaucia86 commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

@cezaraugusto done! :)

@tesseralistesseralis mentioned this pull request Feb 8, 2019
Closed
90 tasks
@cezaraugustocezaraugusto added 🌐 translated Translation is completed for this page and removed needs review A pull request ready to be reviewed labels Feb 8, 2019
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@chmieleski@glaucia86
Translation of the "JS Environment Requirements " page (reactjs#8)
6f652db
* Update reference-javascript-environment-requirements.md
* Corrigido links para o MDN
* modifications
* Improved/Fixed some translations.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhonmikejhonmikejhonmike left review comments
+2 more reviewers
@glaucia86glaucia86glaucia86 approved these changes
@cezaraugustocezaraugustocezaraugusto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chmieleski@cezaraugusto@glaucia86@jhonmike