Skip to content

React without ES6 - #95

Merged
glaucia86 merged 5 commits into
reactjs:masterfrom
gutofoletto:translate/react-without-es6
Mar 3, 2019
Merged

React without ES6#95
glaucia86 merged 5 commits into
reactjs:masterfrom
gutofoletto:translate/react-without-es6

Conversation

@gutofoletto

@gutofolettogutofoletto commented Feb 13, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Translated the React Without ES6 section as mentioned in #1

abnersajr
abnersajr suggested changes Feb 13, 2019
View reviewed changes

@abnersajrabnersajr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algumas pequenas sugestões mas no geral 👍

Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
@abnersajr@gutofoletto
Apply suggestions from code review to fix Portuguese typos
6414976
Co-Authored-By: gutofoletto <gutofoletto@gmail.com>
@gutofoletto

gutofoletto commented Feb 13, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks @abnersajr!

@cezaraugustocezaraugusto added the needs review A pull request ready to be reviewed label Feb 13, 2019
@eduardomoronieduardomoroni added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 14, 2019
eduardomoroni
eduardomoroni previously approved these changes Feb 14, 2019
View reviewed changes

@eduardomoronieduardomoroni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show, uma sugestão seria colocar o link da wikipedia em pt-br

Comment threadcontent/docs/react-without-es6.md Outdated
@eduardomoronieduardomoroni self-assigned this Feb 14, 2019
@eduardomoroni@gutofoletto
changed wikipedia link to point to Portuguese website
cae10ef
Co-Authored-By: gutofoletto <gutofoletto@gmail.com>
glaucia86
glaucia86 suggested changes Feb 14, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gutofoletto pequenas mudanças a serem feitas. Faz as alterações necessárias que logo em seguida estaremos aprovando a sua contribuição. Muito obrigada :)

Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
@glaucia86@gutofoletto
Apply suggestions from Portuguese review
b1296b7
Co-Authored-By: gutofoletto <gutofoletto@gmail.com>
@gutofoletto

gutofoletto commented Feb 19, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks @glaucia86! I updated the PR with your suggestions yesterday ;)
Let me know if there is anything else ^^

@tesseralistesseralis mentioned this pull request Feb 19, 2019
Closed
90 tasks
@tibuurciotibuurcio added needs review A pull request ready to be reviewed feedback addressed and removed needs author response Changes requested needing author's input labels Feb 22, 2019
tibuurcio
tibuurcio suggested changes Feb 24, 2019
View reviewed changes

@tibuurciotibuurcio left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oi @gutofoletto, obrigado pelo tempo dedicado 😄

Seguem apenas algumas sugestões quanto a não traduzir state, que foi definido enquanto as traduções estavam acontecendo.. Após isso já podemos dar merge visto que você já aceitou as mudanças dos outros reviewers.

Valeu 👍

Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
Comment threadcontent/docs/react-without-es6.md Outdated
@tibuurciotibuurcio added needs author response Changes requested needing author's input and removed feedback addressed needs review A pull request ready to be reviewed labels Feb 24, 2019
@glaucia86

glaucia86 commented Feb 25, 2019

Copy link
Copy Markdown
Contributor

@gutofoletto faz as alterações que o @tibuurcio sugeriu ontem (24/02) que logo em seguida iremos aprovar a sua excelente contribuição. Nos sinalize aqui com

cc: @glaucia86@tibuurcio

Que o quanto antes aprovaremos a sua contribuição! :)

@tibuurcio@gutofoletto
changed the word 'estado' to 'state'
c89fdca
Co-Authored-By: gutofoletto <gutofoletto@gmail.com>
@gutofoletto

gutofoletto commented Feb 25, 2019

Copy link
Copy Markdown
ContributorAuthor

@tibuurcio@glaucia86 done! ;)

@netlify

netlifyBot commented Feb 25, 2019

Copy link
Copy Markdown

Deploy preview for pt-br-reactjs ready!

Built with commit c89fdca

https://deploy-preview-95--pt-br-reactjs.netlify.com

1 similar comment
@netlify

netlifyBot commented Feb 25, 2019

Copy link
Copy Markdown

Deploy preview for pt-br-reactjs ready!

Built with commit c89fdca

https://deploy-preview-95--pt-br-reactjs.netlify.com

@tibuurciotibuurcio added the needs +1 Needs another approval before merging label Feb 25, 2019
@tibuurciotibuurcio added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 25, 2019
@gutofoletto

gutofoletto commented Mar 1, 2019

Copy link
Copy Markdown
ContributorAuthor

@glaucia86 Tem alguma coisa que preciso ajustar ainda?

glaucia86
glaucia86 approved these changes Mar 3, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gutofoletto Parabéns! A sua contribuição foi aprovada!
Agradecemos e muito pela sua ajuda!
LGTM 👍

Fazendo merge para a Documentação principal! :)

@glaucia86
glaucia86 merged commit 3760de7 into reactjs:masterMar 3, 2019
@glaucia86glaucia86 added 🌐 translated Translation is completed for this page and removed feedback addressed needs +1 Needs another approval before merging labels Mar 3, 2019
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@gutofoletto@glaucia86
React without ES6 (reactjs#95)
180b2e0
* add react without es6 pt-br translation
* Apply suggestions from code review to fix Portuguese typos
Co-Authored-By: gutofoletto <gutofoletto@gmail.com>
* changed wikipedia link to point to Portuguese website
Co-Authored-By: gutofoletto <gutofoletto@gmail.com>
* Apply suggestions from Portuguese review
Co-Authored-By: gutofoletto <gutofoletto@gmail.com>
* changed the word 'estado' to 'state'
Co-Authored-By: gutofoletto <gutofoletto@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhonmikejhonmikejhonmike approved these changes
+4 more reviewers
@abnersajrabnersajrabnersajr requested changes
@glaucia86glaucia86glaucia86 approved these changes
@tibuurciotibuurciotibuurcio approved these changes
@eduardomoronieduardomoronieduardomoroni left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@eduardomoronieduardomoroni

@glaucia86glaucia86

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@gutofoletto@glaucia86@eduardomoroni@abnersajr@jhonmike@tibuurcio@cezaraugusto