Skip to content

Translate Lifting State Up - #96

Merged
glaucia86 merged 6 commits into
reactjs:masterfrom
gustavobini:lifting-state-up-pt-br
Feb 16, 2019
Merged

Translate Lifting State Up#96
glaucia86 merged 6 commits into
reactjs:masterfrom
gustavobini:lifting-state-up-pt-br

Conversation

@gustavobini

@gustavobinigustavobini commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

@eduardomoronieduardomoroni added the needs +1 Needs another approval before merging label Feb 14, 2019
eduardomoroni
eduardomoroni previously approved these changes Feb 14, 2019
View reviewed changes

@eduardomoronieduardomoroni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show de bola @gustavobini, fiz algumas sugestões mas podemos mergear do jeitinho que está.

Valeu

Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
@eduardomoronieduardomoroni added the needs author response Changes requested needing author's input label Feb 14, 2019
@eduardomoronieduardomoroni self-assigned this Feb 14, 2019
jhonmike
jhonmike reviewed Feb 14, 2019
View reviewed changes
Comment threadcontent/docs/lifting-state-up.md Outdated
@jhonmike

jhonmike commented Feb 14, 2019•
edited
Loading

Copy link
Copy Markdown
Member

acho que não precisa enviar o package-lock.json na diff do seu PR.
Seria legal traduzir também o titulo da pagina.

jhonmike
jhonmike reviewed Feb 14, 2019
View reviewed changes
Comment threadcontent/docs/lifting-state-up.md Outdated
jhonmike
jhonmike reviewed Feb 14, 2019
View reviewed changes
Comment threadcontent/docs/lifting-state-up.md Outdated
@tesseralistesseralis mentioned this pull request Feb 14, 2019
Closed
90 tasks
glaucia86
glaucia86 previously approved these changes Feb 14, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavobini faça as alterações solicitadas por mim e pelo @eduardomoroni que logo em seguida estaremos aprovando a sua contribuição.

Muito obrigada! :)

Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
Comment threadcontent/docs/lifting-state-up.md Outdated
@glaucia86
glaucia86 dismissed their stale reviewFebruary 14, 2019 22:53

precisa realizar algumas alterações.

glaucia86
glaucia86 suggested changes Feb 14, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavobini faça as alterações solicitadas por mim e pelo @eduardomoroni que logo em seguida estaremos aprovando a sua contribuição.

Muito obrigada! :)

Jhon Mike@gustavobini
Apply suggestions from code review
e29c5c7
Translating codepen links
Co-Authored-By: gustavobini <gustavobini@gmail.com>
glaucia86and others added 3 commits February 14, 2019 21:51
@glaucia86@gustavobini
Apply suggestions from code review
39e7994
Fixing grammar errors
Co-Authored-By: gustavobini <gustavobini@gmail.com>
@gustavobini
Making a few translation corrections
100024d
@gustavobini
Delete package-lock.json
73b2efe
@gustavobini

gustavobini commented Feb 15, 2019

Copy link
Copy Markdown
ContributorAuthor

@gustavobini faça as alterações solicitadas por mim e pelo @eduardomoroni que logo em seguida estaremos aprovando a sua contribuição.

Muito obrigada! :)

Prontinho!

@eduardomoronieduardomoroni added feedback addressed and removed needs +1 Needs another approval before merging needs author response Changes requested needing author's input labels Feb 16, 2019
glaucia86
glaucia86 approved these changes Feb 16, 2019
View reviewed changes

@glaucia86glaucia86 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavobini

LGTM 👍

Agradecemos pela sua excelente contribuição! :)

@glaucia86
glaucia86 merged commit b890fbb into reactjs:masterFeb 16, 2019
@cezaraugustocezaraugusto added 🌐 translated Translation is completed for this page and removed feedback addressed labels Feb 17, 2019
devin-ai-integrationBot pushed a commit to WalissonRodrigo/pt-br.react.dev that referenced this pull request Jul 9, 2026
@gustavobini@glaucia86
Translate Lifting State Up (reactjs#96)
7f456d0
* Translating
* Finishing traslationof lifting state up
* Apply suggestions from code review
Translating codepen links
Co-Authored-By: gustavobini <gustavobini@gmail.com>
* Apply suggestions from code review
Fixing grammar errors
Co-Authored-By: gustavobini <gustavobini@gmail.com>
* Making a few translation corrections
* Delete package-lock.json
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhonmikejhonmikejhonmike left review comments
+2 more reviewers
@eduardomoronieduardomoronieduardomoroni approved these changes
@glaucia86glaucia86glaucia86 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@eduardomoronieduardomoroni

@glaucia86glaucia86

Labels

🌐 translatedTranslation is completed for this page

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gustavobini@jhonmike@eduardomoroni@glaucia86@cezaraugusto