Add support for imported propTypes

[echenley]

Importing prop types is a fairly common use case which doesn't appear to be possible at this stage. Any plans to support this pattern?

Example:

// defaultPropTypes.js

import { PropTypes } from 'react';

export default {
 prop1: PropTypes.string
};

// otherPropTypes.js

import { PropTypes } from 'react';

export default {
 prop2: PropTypes.object
};

// MyComponent.jsx

import { Component } from 'react';
import defaultPropTypes from './defaultPropTypes.js';
import otherPropTypes './otherPropTypes.js';

export default class MyComponent extends Component {
 static propTypes = {
 ...defaultPropTypes,
 ...otherPropTypes
 }
 // etc...
}

Results in:

{
 "MyComponent.jsx": {
 "description": ""
 }
}

[fkling]

I guess we could do this for simple cases, where a variable is spread into propTypes (i.e. ...foo, but not ..foo.bar) and that variable resolves to a module import.

I didn't want to make react-docgen make any assumptions about how module identifiers are resolved, but I guess it's fair to assume that it will be CommonJS compatible (i.e. module identifiers refer to npm modules or local files).

Then we could inspect the other file and if it returns an object literal, inspect and merge it as well.

[frontendphil]

+1 :)

[oliviertassinari]

That would be a great feature

[thebuilder]

I've got a similar usecase, but not using spread when injecting the props.

// ILink.js
import {PropTypes} from 'react';

export default PropTypes.shape({
 url: PropTypes.string.isRequired,
 selected: PropTypes.bool,
 target: PropTypes.string,
 title: PropTypes.string.isRequired
});

// MyComponent.jsx

import { Component } from 'react';
import ILink from './ILink.js';
import otherPropTypes './otherPropTypes.js';

export default class MyComponent extends Component {
 static propTypes = {
 link: ILink
 }
 // etc...
}

[danez]

The same idea would also apply to flow types, as they can be also imported. So maybe this "import something" could be abstracted in a way so it makes imported propTypes and flowTypes possible.