Support 'memo(forwardRef(...'

[mfazekas]

While forwardRef(...) is already supported memo(forwardRef(...)) doesn't.

[danez]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

[mfazekas]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

What I see in playground, and in our case also is that this does not work in playground:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

This does work:

importReact,{memo,forwardRef}from'react';exportdefaultReact.memo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

So does this:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>);

I've update the test code in the PR, it still pass, but I'm not sure if this is the proper way of fixing the issue or there is a simpler fix.

[danez]

Thanks again. I looked into this more and discovered that the underlying issue is that isReactBuiltinCall was wrongly detecting forwardRef just because it was imported.

[mfazekas]

While forwardRef(...) is already supported memo(forwardRef(...)) doesn't.

[danez]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

[mfazekas]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

What I see in playground, and in our case also is that this does not work in playground:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

This does work:

importReact,{memo,forwardRef}from'react';exportdefaultReact.memo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

So does this:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>);

I've update the test code in the PR, it still pass, but I'm not sure if this is the proper way of fixing the issue or there is a simpler fix.

[danez]

Thanks again. I looked into this more and discovered that the underlying issue is that isReactBuiltinCall was wrongly detecting forwardRef just because it was imported.

[mfazekas]

While forwardRef(...) is already supported memo(forwardRef(...)) doesn't.

[danez]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

[mfazekas]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

What I see in playground, and in our case also is that this does not work in playground:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

This does work:

importReact,{memo,forwardRef}from'react';exportdefaultReact.memo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

So does this:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>);

I've update the test code in the PR, it still pass, but I'm not sure if this is the proper way of fixing the issue or there is a simpler fix.

[danez]

Thanks again. I looked into this more and discovered that the underlying issue is that isReactBuiltinCall was wrongly detecting forwardRef just because it was imported.

[mfazekas]

While forwardRef(...) is already supported memo(forwardRef(...)) doesn't.

[danez]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

[mfazekas]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

What I see in playground, and in our case also is that this does not work in playground:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

This does work:

importReact,{memo,forwardRef}from'react';exportdefaultReact.memo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

So does this:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>);

I've update the test code in the PR, it still pass, but I'm not sure if this is the proper way of fixing the issue or there is a simpler fix.

[danez]

Thanks again. I looked into this more and discovered that the underlying issue is that isReactBuiltinCall was wrongly detecting forwardRef just because it was imported.

[mfazekas]

While forwardRef(...) is already supported memo(forwardRef(...)) doesn't.

[danez]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

[mfazekas]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

What I see in playground, and in our case also is that this does not work in playground:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

This does work:

importReact,{memo,forwardRef}from'react';exportdefaultReact.memo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

So does this:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>);

I've update the test code in the PR, it still pass, but I'm not sure if this is the proper way of fixing the issue or there is a simpler fix.

[danez]

Thanks again. I looked into this more and discovered that the underlying issue is that isReactBuiltinCall was wrongly detecting forwardRef just because it was imported.

[mfazekas]

While forwardRef(...) is already supported memo(forwardRef(...)) doesn't.

[danez]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

[mfazekas]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

What I see in playground, and in our case also is that this does not work in playground:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

This does work:

importReact,{memo,forwardRef}from'react';exportdefaultReact.memo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

So does this:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>);

I've update the test code in the PR, it still pass, but I'm not sure if this is the proper way of fixing the issue or there is a simpler fix.

[danez]

Thanks again. I looked into this more and discovered that the underlying issue is that isReactBuiltinCall was wrongly detecting forwardRef just because it was imported.

[mfazekas]

While forwardRef(...) is already supported memo(forwardRef(...)) doesn't.

[danez]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

[mfazekas]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

What I see in playground, and in our case also is that this does not work in playground:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

This does work:

importReact,{memo,forwardRef}from'react';exportdefaultReact.memo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

So does this:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>);

I've update the test code in the PR, it still pass, but I'm not sure if this is the proper way of fixing the issue or there is a simpler fix.

[danez]

Thanks again. I looked into this more and discovered that the underlying issue is that isReactBuiltinCall was wrongly detecting forwardRef just because it was imported.

[mfazekas]

While forwardRef(...) is already supported memo(forwardRef(...)) doesn't.

[danez]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

[mfazekas]

Thanks for contributing.

Could you show me an example of what is not working? When I use the example from the test and enter it into the playground I already get the same result as in the test.

import React from 'react';
export default React.memo(React.forwardRef(({ foo = 'bar' }, ref) => <div ref={ref}>{foo}</div>));

What I see in playground, and in our case also is that this does not work in playground:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

This does work:

importReact,{memo,forwardRef}from'react';exportdefaultReact.memo(forwardRef(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>));

So does this:

importReact,{memo,forwardRef}from'react';exportdefaultmemo(({ foo ='bar'},ref)=><divref={ref}>{foo}</div>);

I've update the test code in the PR, it still pass, but I'm not sure if this is the proper way of fixing the issue or there is a simpler fix.

[danez]

Thanks again. I looked into this more and discovered that the underlying issue is that isReactBuiltinCall was wrongly detecting forwardRef just because it was imported.