🐛 Fix bug that prevents loading assets with webpacker-dev-server

[joeyparis]

Issue #739

In certain circumstances webpacker-dev-server includes the full path
(protocol and host with port) in the paths generated for the
packs/manifest.json file. This addition removes the protocol, host, and
port from the asset path when present allowing assets to be correctly
loaded.

Summary

Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

If you are updating any of the CHANGELOG files or are asked to update the
CHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.

Thanks for contributing!

[BookOfGreg]

I'll be honest, I spent some time trying to replicate the issue so that I could write a test for this and I couldn't actually trigger it again though I have seen it in the past. Going to merge this for now, it's a safe change unless someone does something truly odd like putting casual URLs in their file names.

Thanks for the contribution, hope you stick around and help out some more, been a pleasure @joeyparis 🎉

[joeyparis]

Issue #739

In certain circumstances webpacker-dev-server includes the full path
(protocol and host with port) in the paths generated for the
packs/manifest.json file. This addition removes the protocol, host, and
port from the asset path when present allowing assets to be correctly
loaded.

Summary

Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

If you are updating any of the CHANGELOG files or are asked to update the
CHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.

Thanks for contributing!

[BookOfGreg]

I'll be honest, I spent some time trying to replicate the issue so that I could write a test for this and I couldn't actually trigger it again though I have seen it in the past. Going to merge this for now, it's a safe change unless someone does something truly odd like putting casual URLs in their file names.

Thanks for the contribution, hope you stick around and help out some more, been a pleasure @joeyparis 🎉

[joeyparis]

Issue #739

In certain circumstances webpacker-dev-server includes the full path
(protocol and host with port) in the paths generated for the
packs/manifest.json file. This addition removes the protocol, host, and
port from the asset path when present allowing assets to be correctly
loaded.

Summary

Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

If you are updating any of the CHANGELOG files or are asked to update the
CHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.

Thanks for contributing!

[BookOfGreg]

I'll be honest, I spent some time trying to replicate the issue so that I could write a test for this and I couldn't actually trigger it again though I have seen it in the past. Going to merge this for now, it's a safe change unless someone does something truly odd like putting casual URLs in their file names.

Thanks for the contribution, hope you stick around and help out some more, been a pleasure @joeyparis 🎉

[joeyparis]

Issue #739

In certain circumstances webpacker-dev-server includes the full path
(protocol and host with port) in the paths generated for the
packs/manifest.json file. This addition removes the protocol, host, and
port from the asset path when present allowing assets to be correctly
loaded.

Summary

Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

If you are updating any of the CHANGELOG files or are asked to update the
CHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.

Thanks for contributing!

[BookOfGreg]

I'll be honest, I spent some time trying to replicate the issue so that I could write a test for this and I couldn't actually trigger it again though I have seen it in the past. Going to merge this for now, it's a safe change unless someone does something truly odd like putting casual URLs in their file names.

Thanks for the contribution, hope you stick around and help out some more, been a pleasure @joeyparis 🎉

[joeyparis]

Issue #739

In certain circumstances webpacker-dev-server includes the full path
(protocol and host with port) in the paths generated for the
packs/manifest.json file. This addition removes the protocol, host, and
port from the asset path when present allowing assets to be correctly
loaded.

Summary

Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

If you are updating any of the CHANGELOG files or are asked to update the
CHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.

Thanks for contributing!

[BookOfGreg]

I'll be honest, I spent some time trying to replicate the issue so that I could write a test for this and I couldn't actually trigger it again though I have seen it in the past. Going to merge this for now, it's a safe change unless someone does something truly odd like putting casual URLs in their file names.

Thanks for the contribution, hope you stick around and help out some more, been a pleasure @joeyparis 🎉

[joeyparis]

Issue #739

In certain circumstances webpacker-dev-server includes the full path
(protocol and host with port) in the paths generated for the
packs/manifest.json file. This addition removes the protocol, host, and
port from the asset path when present allowing assets to be correctly
loaded.

Summary

Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

If you are updating any of the CHANGELOG files or are asked to update the
CHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.

Thanks for contributing!

[BookOfGreg]

I'll be honest, I spent some time trying to replicate the issue so that I could write a test for this and I couldn't actually trigger it again though I have seen it in the past. Going to merge this for now, it's a safe change unless someone does something truly odd like putting casual URLs in their file names.

Thanks for the contribution, hope you stick around and help out some more, been a pleasure @joeyparis 🎉

[joeyparis]

Issue #739

In certain circumstances webpacker-dev-server includes the full path
(protocol and host with port) in the paths generated for the
packs/manifest.json file. This addition removes the protocol, host, and
port from the asset path when present allowing assets to be correctly
loaded.

Summary

Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

If you are updating any of the CHANGELOG files or are asked to update the
CHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.

Thanks for contributing!

[BookOfGreg]

I'll be honest, I spent some time trying to replicate the issue so that I could write a test for this and I couldn't actually trigger it again though I have seen it in the past. Going to merge this for now, it's a safe change unless someone does something truly odd like putting casual URLs in their file names.

Thanks for the contribution, hope you stick around and help out some more, been a pleasure @joeyparis 🎉

[joeyparis]

Issue #739

In certain circumstances webpacker-dev-server includes the full path
(protocol and host with port) in the paths generated for the
packs/manifest.json file. This addition removes the protocol, host, and
port from the asset path when present allowing assets to be correctly
loaded.

Summary

Provide a general description of the code changes in your pull
request... were there any bugs you had fixed? If so, mention them. If
these bugs have open GitHub issues, be sure to tag them here as well,
to keep the conversation linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

If you are updating any of the CHANGELOG files or are asked to update the
CHANGELOG files by reviewers, please add the CHANGELOG entry at the top of the file.

Thanks for contributing!

[BookOfGreg]

I'll be honest, I spent some time trying to replicate the issue so that I could write a test for this and I couldn't actually trigger it again though I have seen it in the past. Going to merge this for now, it's a safe change unless someone does something truly odd like putting casual URLs in their file names.

Thanks for the contribution, hope you stick around and help out some more, been a pleasure @joeyparis 🎉