Uh oh!
There was an error while loading. Please reload this page.
Strip custom prop-types in production - #448
Merged
Merged
Conversation
Minified size with bundled dependencies before 17.53 KB After 16.66 KB
jquense
approved these changes
Jan 13, 2019
jquense
left a comment
Contributor
There was a problem hiding this comment.
Lgtm, I'm assuming the direct assignment to .propTypes is because the Babel plugin doesn't strip them otherwise?
TrySound
commented
Jan 13, 2019
ContributorAuthor
Yep |
TrySound
commented
Jan 14, 2019
ContributorAuthor
@jquense Is this good now? |
jquense pushed a commit
that referenced
this pull request
Jan 14, 2019
## [2.5.3](v2.5.2...v2.5.3) (2019-01-14) ### Bug Fixes * strip custom prop-types in production ([#448](#448)) ([46fa20f](46fa20f))
jquense
commented
Jan 14, 2019
Contributor
🎉 This PR is included in version 2.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
oliviertassinari
commented
Jan 14, 2019
Contributor
-200 B gzipped https://bundlephobia.com/result?p=react-transition-group@2.5.3 🚀 |
jquense
commented
Jan 14, 2019
Contributor
hmm we are still including the prop-types library tho. seems like the import isn't getting stripped |
oliviertassinari
commented
Jan 14, 2019
Contributor
@jquense It's not. I wish the babel plugin was doing such. |
Contributor
It's another gain potential. https://bundlephobia.com/result?p=prop-types@15.6.2. However, I'm not sure how we can make it work with ESM modules. Conditionally importing modules? 🤔. |
TrySound
commented
Jan 14, 2019
ContributorAuthor
It's because of old context api I guess |
errendir added a commit
to errendir/react-transition-group
that referenced
this pull request
Feb 14, 2019
…d-compatible * origin/master: chore: bundle UMD with rollup (reactjs#449) chore(release): 2.5.3 [skip ci] fix: strip custom prop-types in production (reactjs#448) chore: fix storybook (reactjs#445) chore(release): 2.5.2 [skip ci] fix: pass appear to CSSTransition callbacks (reactjs#441) docs: Fix type declaration comment (reactjs#439) chore(release): 2.5.1 [skip ci] fix: prevent calling setState in TransitionGroup if it has been unmounted (reactjs#435)
errendir added a commit
to errendir/react-transition-group
that referenced
this pull request
Feb 14, 2019
…d-compatible * origin/master: chore: bundle UMD with rollup (reactjs#449) chore(release): 2.5.3 [skip ci] fix: strip custom prop-types in production (reactjs#448) chore: fix storybook (reactjs#445) chore(release): 2.5.2 [skip ci] fix: pass appear to CSSTransition callbacks (reactjs#441) docs: Fix type declaration comment (reactjs#439) chore(release): 2.5.1 [skip ci] fix: prevent calling setState in TransitionGroup if it has been unmounted (reactjs#435)
This was referenced Sep 24, 2019
This was referenced Mar 26, 2020
johnfrench3 pushed a commit
to johnfrench3/transition-group-react
that referenced
this pull request
Nov 2, 2022
## [2.5.3](reactjs/react-transition-group@v2.5.2...v2.5.3) (2019-01-14) ### Bug Fixes * strip custom prop-types in production ([#448](reactjs/react-transition-group#448)) ([46fa20f](reactjs/react-transition-group@46fa20f))
patrickm68 added a commit
to patrickm68/react-transition-group-developer
that referenced
this pull request
Dec 1, 2022
## [2.5.3](reactjs/react-transition-group@v2.5.2...v2.5.3) (2019-01-14) ### Bug Fixes * strip custom prop-types in production ([#448](reactjs/react-transition-group#448)) ([46fa20f](reactjs/react-transition-group@46fa20f))
shaikdev2 pushed a commit
to shaikdev2/transition-group-react
that referenced
this pull request
Jun 9, 2023
## [2.5.3](reactjs/react-transition-group@v2.5.2...v2.5.3) (2019-01-14) ### Bug Fixes * strip custom prop-types in production ([#448](reactjs/react-transition-group#448)) ([46fa20f](reactjs/react-transition-group@46fa20f))
GreenCat1996 added a commit
to GreenCat1996/react-transition-group
that referenced
this pull request
Aug 1, 2023
## [2.5.3](reactjs/react-transition-group@v2.5.2...v2.5.3) (2019-01-14) ### Bug Fixes * strip custom prop-types in production ([#448](reactjs/react-transition-group#448)) ([46fa20f](reactjs/react-transition-group@46fa20f))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minified size with bundled dependencies before
17.53 KB
After
16.66 KB