Uh oh!
There was an error while loading. Please reload this page.
Add CircleCI config - #131
Conversation
reactjs-bot
commented
Oct 11, 2017
Deploy preview ready! Built with commit 086322a |
bvaughn
left a comment
There was a problem hiding this comment.
Sweet! Thanks!
Left a comment about yarn.lock file. What are your thoughts?
| - image: circleci/node:latest | ||
| steps: | ||
| - checkout | ||
| - restore_cache: |
There was a problem hiding this comment.
Do we need a step to explicitly install Yarn if it's not already installed? The React repo's circle.yml file has this:
pre:
# This is equivalent to $TRAVIS_COMMIT_RANGE
- echo $CIRCLE_COMPARE_URL | cut -d/ -f7
# install yarn if it's not already installed
- |
if [[ ! -e ~/.yarn/bin/yarn || $(yarn --version) != "${YARN_VERSION}" ]]; then
curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version $YARN_VERSION
fi
Maybe this isn't necessary with the 2.0 API. The 1.0 API docs have a section about how to enable Yarn which the 2.0 docs don't have. Maybe it just works out of the box now? 😁 Let's try and see!
There was a problem hiding this comment.
Pretty sure it’s already installed on v2
There was a problem hiding this comment.
Yeah, seems like that's the case.
| - checkout | ||
| - restore_cache: | ||
| keys: | ||
| - dependencies-{{ checksum "package.json" }} |
There was a problem hiding this comment.
I wonder if we should checksum "yarn.lock" instead? Seems like that may be better?
bvaughn
left a comment
There was a problem hiding this comment.
Let's iterate on this. I'll move forward with the package.json checksum now and we can chat more about the lockfile alternative.
bvaughn
commented
Oct 11, 2017
Looks good so far 👍 The first build commit (c4aaa15) failed: https://circleci.com/gh/reactjs/reactjs.org/1 This was because a Prettier issue had slipped in. I fixed it (42372b2) and the second build seems happy: https://circleci.com/gh/reactjs/reactjs.org/2 😄 |
bvaughn
commented
Oct 11, 2017
…js#131) * translate navbar * Update content/docs/nav.yml Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com> * Apply suggestions from code review Co-Authored-By: WeslleyNasRocha <weslleytato.12@gmail.com>
This intends to fix the third and final item for #67.
Basically just runs the
ci-checkscript upon every build, as well as caching the project dependencies 🤗.