Skip to content

fix: googleTranslate breaking terminal blocks - #3993

Merged
nearestnabors merged 2 commits into
reactjs:betafrom
shrirambalaji:fix-google-translate-breaking-terminal-blocks
Oct 24, 2021
Merged

fix: googleTranslate breaking terminal blocks#3993
nearestnabors merged 2 commits into
reactjs:betafrom
shrirambalaji:fix-google-translate-breaking-terminal-blocks

Conversation

@shrirambalaji

@shrirambalajishrirambalaji commented Oct 24, 2021

Copy link
Copy Markdown
Contributor

Follow up to #3984. cc @rachelnabors

image

@shrirambalaji

shrirambalaji commented Oct 24, 2021

Copy link
Copy Markdown
ContributorAuthor

@rachelnabors quick question: Readme.md mentions a yarn check-all script, which is missing. I'm assuming there are CI warnings too as local prettier, eslint aren't run locally.

Should the docs maybe updated to the right steps instead? (I'll make a PR for it)

@nearestnabors

nearestnabors commented Oct 24, 2021

Copy link
Copy Markdown
Contributor

Awesome! Thanks for the fast follow up!

sm_thanks

As for the Readme.md, that doesn't apply to the beta docs site IIRC. We might need to rethink it. Thanks for the reminder!

@nearestnabors
nearestnabors merged commit 7fcceca into reactjs:betaOct 24, 2021
gaearon pushed a commit that referenced this pull request Oct 28, 2021
* fix: googleTranslate breaking terminal blocks
* chore: prettier magic
gaearon pushed a commit that referenced this pull request Oct 28, 2021
* fix: googleTranslate breaking terminal blocks
* chore: prettier magic
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@shrirambalaji@nearestnabors@facebook-github-bot