Uh oh!
There was an error while loading. Please reload this page.
Fix SandpackWithHTMLOutput to use src dir - #6613
Merged
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
mattcarrollcode
marked this pull request as ready for review
February 6, 2024 17:14
rickhanlonii
approved these changes
Feb 6, 2024
trevlee0212 added a commit
to trevlee0212/react.dev
that referenced
this pull request
Feb 7, 2024
Fix SandpackWithHTMLOutput to use src dir (reactjs#6613)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SandpackWithHTMLOutputis broken, likely since #6496 this PR fixes the component by prefixing all files exceptpackage.jsonwithsrcso the files are all in the place CodeSandbox expects. This broke 9 sandpacks across 5 pages. Fixes#6612Preview links
<link>page<meta>page<script>page<style>page<title>page