Skip to content

Add initial Rules of React docs - #6680

Merged
poteto merged 37 commits into
mainfrom
lt/rules-of-react
Mar 15, 2024
Merged

Add initial Rules of React docs#6680
poteto merged 37 commits into
mainfrom
lt/rules-of-react

Conversation

@poteto

@potetopoteto commented Mar 5, 2024

Copy link
Copy Markdown
Member

@vercel

vercelBot commented Mar 5, 2024•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
react-dev✅ Ready (Inspect)Visit PreviewMar 15, 2024 3:55pm

@github-actions

github-actionsBot commented Mar 5, 2024•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

PageSize (compressed)First Load
/[[...markdownPath]]81.52 KB(🟡 +87 B)185.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

josephsavona
josephsavona reviewed Mar 5, 2024
View reviewed changes
Comment threadsrc/content/reference/rules/index.md Outdated
@poteto
potetoforce-pushed the lt/rules-of-react branch from 06d10d0 to bf7d330CompareMarch 6, 2024 21:38
kassens
kassens reviewed Mar 6, 2024
View reviewed changes
Comment threadsrc/content/reference/rules/components-must-be-idempotent.md Outdated
kassens
kassens reviewed Mar 6, 2024
View reviewed changes
Comment threadsrc/content/reference/rules/never-call-component-functions-directly.md Outdated
kassens
kassens reviewed Mar 6, 2024
View reviewed changes
Comment threadsrc/content/reference/rules/never-call-component-functions-directly.md Outdated
eps1lon
eps1lon reviewed Mar 6, 2024
View reviewed changes
Comment threadsrc/content/reference/rules/never-pass-around-hooks-as-regular-values.md Outdated
eps1lon
eps1lon reviewed Mar 6, 2024
View reviewed changes

@eps1loneps1lon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Finally something to link to 🥳

jackpope
jackpope reviewed Mar 7, 2024
View reviewed changes
Comment threadsrc/content/reference/rules/index.md Outdated
Comment threadsrc/content/reference/rules/side-effects-must-run-outside-of-render.md Outdated
Comment threadsrc/content/reference/rules/never-call-component-functions-directly.md Outdated
Comment threadsrc/content/reference/rules/never-pass-around-hooks-as-regular-values.md Outdated
Comment threadsrc/content/reference/rules/never-pass-around-hooks-as-regular-values.md Outdated
Comment threadsrc/content/reference/rules/only-call-hooks-at-the-top-level.md Outdated
@poteto
potetoforce-pushed the lt/rules-of-react branch from d9e429d to 9a8fc09CompareMarch 8, 2024 20:23
pwbriggs
pwbriggs reviewed Mar 11, 2024
View reviewed changes
Comment threadsrc/content/reference/rules/index.md Outdated
@potetopoteto changed the title WIP for early feedbackAdd initial Rules of React docsMar 12, 2024
@poteto
poteto marked this pull request as ready for review March 12, 2024 16:19
mattcarrollcode
mattcarrollcode reviewed Mar 14, 2024
View reviewed changes
Comment threadsrc/sidebarReference.json
Comment threadsrc/content/reference/rules/index.md Outdated
Comment threadsrc/content/reference/rules/index.md Outdated
@poteto
poteto merged commit 0dc1b31 into mainMar 15, 2024
@poteto
poteto deleted the lt/rules-of-react branch March 15, 2024 16:00
@stephan-noelstephan-noel mentioned this pull request Mar 23, 2024
Closed
@stephan-noelstephan-noel mentioned this pull request Apr 27, 2024
Open
@AhmedBasetAhmedBaset mentioned this pull request Jun 17, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kassenskassenskassens left review comments
@rickhanloniirickhanloniirickhanlonii left review comments
@josephsavonajosephsavonajosephsavona left review comments
@mattcarrollcodemattcarrollcodemattcarrollcode left review comments
@jackpopejackpopejackpope left review comments
@eps1loneps1loneps1lon left review comments
@harish-sethuramanharish-sethuramanharish-sethuraman left review comments
+1 more reviewer
@pwbriggspwbriggspwbriggs left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA SignedReact Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@poteto@kassens@rickhanlonii@josephsavona@mattcarrollcode@jackpope@eps1lon@harish-sethuraman@pwbriggs@facebook-github-bot@gsathya