Uh oh!
There was an error while loading. Please reload this page.
Fix stylesheet precedence example - #7235
Merged
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
gaearon
approved these changes
Dec 16, 2024
gaearon
left a comment
Member
There was a problem hiding this comment.
omg thank you, this was so confusing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
precedenceprop documentation for<style>and<link>was fixed last May in this pull request:#6908
(Precedence is now using any name, instead of "high", "medium" or "low")
But the code example accompanying the
<link>documentation was not fixed.There was even a comment in the doc about the fact that precedence didn't seem to work. -- It did work, it's just that it's more of a grouping behavior than an ordering behavior. So you need at least 3
<link>to visibly show that grouping behavior.