Skip to content

Fix setup page#7607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickhanlonii merged 2 commits into from
Feb 18, 2025
Merged

Fix setup page #7607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbbee8b
Remove starting react project from setup page
jasonqiu212 Feb 15, 2025
7ee55cf
Fix typo
jasonqiu212 Feb 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/content/learn/setup.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ title: Setup
---
<Intro>

React integrates with tools like editors, TypeScript, browser extensions, and compliers. This section will help you get your environment set up.
React integrates with tools like editors, TypeScript, browser extensions, and compilers. This section will help you get your environment set up.

</Intro>

Expand All@@ -23,10 +23,6 @@ React Developer Tools is a browser extension that can inspect React components,

React Compiler is a tool that automatically optimizes your React app. [Learn more](/learn/react-compiler).

## Start a React Project from scratch {/*start-a-react-project-from-scratch*/}

If you want to build your own framework, you can [start a React project from scratch](/learn/start-a-react-project-from-scratch).

@gaearongaearonFeb 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of being deleted, this should probably point to /learn/building-a-react-framework?

@gaearongaearonFeb 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii

@jasonqiu212jasonqiu212Feb 16, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gaearon, Apologies, I should have clarified my rationale. I initially wanted to link /learn/building-a-react-framework too. However, it felt out of place in the Setup page, since the /learn/building-a-react-framework page is already linked in the Installation page.

@rickhanlonii Could you please clarify if the /learn/building-a-react-framework page should be linked here or if the section should be removed entirely?

@elitalpaelitalpaFeb 18, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the /learn/building-a-react-framework page just got renamed to /learn/build-a-react-app-from-scratch in #7624

Also /learn/start-a-react-project-from-scratch seems to not be a valid url anymore (but this url is still mentioned on the learn/setup page) :
image

image

I guess the section should be renamed or removed, currently the url is not valid and results in a "not found" error.

Edit : saw afterwards that other issues already mention this "not found" error for the link and it's why this PR exists, hope a decision will be made


## Next steps {/*next-steps*/}

Head to the [Quick Start](/learn) guide for a tour of the most important React concepts you will encounter every day.