Skip to content

Translation Using the Effect Hook - #112

Merged
another-guy merged 9 commits into
reactjs:masterfrom
sqts:hooks-effect
Feb 25, 2019
Merged

Translation Using the Effect Hook#112
another-guy merged 9 commits into
reactjs:masterfrom
sqts:hooks-effect

Conversation

@sqts

@sqtssqts commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@sqtssqts mentioned this pull request Feb 13, 2019
Closed
88 tasks
lex111
lex111 reviewed Feb 13, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Первые предложения, можно принять сразу с гитхаба.

Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
@lex111@sqts
Updated according to@lex111review
794a393
Co-Authored-By: Hisagr <sergio.kuts@gmail.com>
@another-guyanother-guy added the work in progress Author opened the pull-request but it's still being worked on label Feb 13, 2019
@lex111lex111 added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 14, 2019
lex111
lex111 reviewed Feb 14, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Всё отлично, последние с моей стороны предложения:

Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
ntishkevich
ntishkevich reviewed Feb 15, 2019
View reviewed changes
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
@lex111lex111 added the work in progress Author opened the pull-request but it's still being worked on label Feb 16, 2019
@lex111lex111 removed the work in progress Author opened the pull-request but it's still being worked on label Feb 21, 2019
another-guy
another-guy suggested changes Feb 22, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Много комментариев по стилю и упрощению, но и страница оказалась недюжинная 💪 !

Спасибо, @Hisagr !! 💯

Comment threadcontent/docs/hooks-effect.md
```

This snippet is based on the [counter example from the previous page](/docs/hooks-state.html), but we added a new feature to it: we set the document title to a custom message including the number of clicks.
Этот фрагмент основан на [примере со счётчиком из предыдущей страницы](/docs/hooks-state.html), только мы добавили новый функционал: мы изменяем заголовок документа на пользовательское сообщение, которое также содержит количество нажатий кнопки.

@another-guyanother-guyFeb 22, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Этот фрагмент основан на [примере со счётчиком из предыдущей страницы](/docs/hooks-state.html), только мы добавили новый функционал: мы изменяем заголовок документа на пользовательское сообщение, которое также содержит количество нажатий кнопки.
Этот фрагмент основан на [примере со счётчиком из предыдущей страницы](/docs/hooks-state.html), только мы добавили новый функциональность: мы изменяем заголовок документа на пользовательское сообщение, которое также содержит количество нажатий кнопки.

@another-guyanother-guyFeb 22, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В другом PR договорились писать именно как функционалЬНОСТЬ.

@sqtssqtsFeb 25, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

новый -> новую тогда?

Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
Comment threadcontent/docs/hooks-effect.md Outdated
@another-guyanother-guy removed their assignment Feb 22, 2019
@another-guy@sqts
Updated according to@another-guyreview
24f7a5a
Co-Authored-By: Hisagr <sergio.kuts@gmail.com>
@netlify

netlifyBot commented Feb 25, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 24f7a5a

https://deploy-preview-112--ru-reactjs.netlify.com

1 similar comment
@netlify

netlifyBot commented Feb 25, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 24f7a5a

https://deploy-preview-112--ru-reactjs.netlify.com

another-guy
another-guy approved these changes Feb 25, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Замечательно! Спасибо, @Hisagr !!! 💯 🎉

@another-guyanother-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Feb 25, 2019
@another-guy
another-guy merged commit fada179 into reactjs:masterFeb 25, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@ntishkevichntishkevichntishkevich left review comments
@lex111lex111lex111 approved these changes
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sqts@lex111@another-guy@ntishkevich