Skip to content

Проверка типов с помощью PropTypes - #129

Merged
lex111 merged 26 commits into
reactjs:masterfrom
vvscode:typechecking-with-proptypes
Feb 20, 2019
Merged

Проверка типов с помощью PropTypes#129
lex111 merged 26 commits into
reactjs:masterfrom
vvscode:typechecking-with-proptypes

Conversation

@vvscode

@vvscodevvscode commented Feb 14, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tesseralistesseralis mentioned this pull request Feb 14, 2019
Closed
88 tasks
@another-guyanother-guy added the needs review A pull request ready to be reviewed label Feb 14, 2019
angryermine
angryermine reviewed Feb 14, 2019
View reviewed changes

@angryermineangryermine left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет! Во всех источниках, что я нашел, "по умолчанию" пишется без дефиса.

Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
angryermineand others added 6 commits February 14, 2019 12:52
@angryermine@vvscode
Update content/docs/typechecking-with-proptypes.md
cea2850
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@angryermine@vvscode
Update content/docs/typechecking-with-proptypes.md
d477a7e
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@angryermine@vvscode
Update content/docs/typechecking-with-proptypes.md
fa3cdb5
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@angryermine@vvscode
Update content/docs/typechecking-with-proptypes.md
36aa870
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@angryermine@vvscode
Update content/docs/typechecking-with-proptypes.md
26fe782
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@angryermine@vvscode
Update content/docs/typechecking-with-proptypes.md
bc08962
Co-Authored-By: vvscode <v.vanchuk@tut.by>
lex111
lex111 reviewed Feb 14, 2019
View reviewed changes
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
lex111and others added 11 commits February 14, 2019 20:17
@lex111@vvscode
Update content/docs/typechecking-with-proptypes.md
eda2c74
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/typechecking-with-proptypes.md
56c6721
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/typechecking-with-proptypes.md
a3adcef
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/typechecking-with-proptypes.md
247b333
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/typechecking-with-proptypes.md
f3dfab8
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/typechecking-with-proptypes.md
3d7221b
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/typechecking-with-proptypes.md
33af50a
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/typechecking-with-proptypes.md
736b825
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/typechecking-with-proptypes.md
a5e16f9
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/typechecking-with-proptypes.md
bac38ff
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/typechecking-with-proptypes.md
d82b464
Co-Authored-By: vvscode <v.vanchuk@tut.by>
ntishkevich
ntishkevich reviewed Feb 14, 2019
View reviewed changes
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
ntishkevichand others added 5 commits February 15, 2019 08:09
@ntishkevich@vvscode
Update content/docs/typechecking-with-proptypes.md
52567f5
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@ntishkevich@vvscode
Update content/docs/typechecking-with-proptypes.md
fde8f7a
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@ntishkevich@vvscode
Update content/docs/typechecking-with-proptypes.md
1a6f305
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@vvscode
props -> пропсы
4eff932
@lex111@vvscode
Update content/docs/typechecking-with-proptypes.md
7d69431
Co-Authored-By: vvscode <v.vanchuk@tut.by>
another-guy
another-guy approved these changes Feb 20, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень недурно! У меня только одно предложение по тексту.

Спасибо, @vvscode ! 🎉

Comment threadcontent/docs/typechecking-with-proptypes.md Outdated
@another-guyanother-guy removed their assignment Feb 20, 2019
@lex111
lex111 merged commit 69c7a4d into reactjs:masterFeb 20, 2019
@lex111

lex111 commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

@vvscode спасибо, а также @lfedorov, @gcor, @ntishkevich и @another-guy за ревью!

@another-guyanother-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Feb 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers
@angryermineangryermineangryermine left review comments
@lex111lex111lex111 approved these changes
@gcorgcorgcor left review comments
@ntishkevichntishkevichntishkevich left review comments
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vvscode@lex111@angryermine@gcor@another-guy@ntishkevich