Skip to content

Translate "Don't Call PropTypes Warning" - #143

Merged
lex111 merged 11 commits into
masterfrom
dont-call-proptypes
Feb 21, 2019
Merged

Translate "Don't Call PropTypes Warning"#143
lex111 merged 11 commits into
masterfrom
dont-call-proptypes

Conversation

@lex111

@lex111lex111 commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tesseralistesseralis mentioned this pull request Feb 15, 2019
Closed
88 tasks
@lex111lex111 added the needs review A pull request ready to be reviewed label Feb 15, 2019
ntishkevich
ntishkevich reviewed Feb 15, 2019
View reviewed changes
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
ntishkevichand others added 2 commits February 15, 2019 07:46
@ntishkevich@lex111
Update content/warnings/dont-call-proptypes.md
f23af2c
Co-Authored-By: lex111 <lex61rus@gmail.com>
@ntishkevich@lex111
Update content/warnings/dont-call-proptypes.md
6c02d5d
Co-Authored-By: lex111 <lex61rus@gmail.com>
gcor
gcor reviewed Feb 15, 2019
View reviewed changes
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
> Примечание:
>
> `React.PropTypes` has moved into a different package since React v15.5. Please use [the `prop-types` library instead](https://www.npmjs.com/package/prop-types).
> С версии React 15.5 `React.PropTypes` были вынесены в отдельный пакет. Так что используйте [библиотеку `prop-types`](https://www.npmjs.com/package/prop-types).

@gcorgcorFeb 15, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> С версии React 15.5 `React.PropTypes` были вынесены в отдельный пакет. Так что используйте [библиотеку `prop-types`](https://www.npmjs.com/package/prop-types).
> С версии React 15.5 `React.PropTypes` были вынесены в отдельный пакет. Вместо этого используйте [библиотеку `prop-types`](https://www.npmjs.com/package/prop-types).

@lex111lex111Feb 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: обновить файл с проверкой пропсов (брал оттуда это примечание, нужно синхронизировать)

@another-guyanother-guyFeb 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lex111 если это уже исправлено, то можно мёржить. 🎉

gcorand others added 4 commits February 15, 2019 12:20
@gcor@lex111
Update content/warnings/dont-call-proptypes.md
37da138
Co-Authored-By: lex111 <lex61rus@gmail.com>
@gcor@lex111
Update content/warnings/dont-call-proptypes.md
13ed91a
Co-Authored-By: lex111 <lex61rus@gmail.com>
@gcor@lex111
Update content/warnings/dont-call-proptypes.md
5a53798
Co-Authored-By: lex111 <lex61rus@gmail.com>
@gcor@lex111
Update content/warnings/dont-call-proptypes.md
ff21419
Co-Authored-By: lex111 <lex61rus@gmail.com>
gcor
gcor reviewed Feb 15, 2019
View reviewed changes
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
@gcor@lex111
Update content/warnings/dont-call-proptypes.md
6f4f602
Co-Authored-By: lex111 <lex61rus@gmail.com>
@gcorgcor mentioned this pull request Feb 15, 2019
Merged
@gcor@lex111
Update content/warnings/dont-call-proptypes.md
a2beadc
Co-Authored-By: lex111 <lex61rus@gmail.com>
another-guy
another-guy approved these changes Feb 21, 2019
View reviewed changes
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
Comment threadcontent/warnings/dont-call-proptypes.md Outdated
@another-guyanother-guy removed their assignment Feb 21, 2019
@another-guyanother-guy removed the needs review A pull request ready to be reviewed label Feb 21, 2019
@lex111
lex111 merged commit f874e14 into masterFeb 21, 2019
@netlify

netlifyBot commented Feb 21, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs failed.

Built with commit 37fcbba

https://app.netlify.com/sites/ru-reactjs/deploys/5c6ee835617b1f0007846513

@netlify

netlifyBot commented Feb 21, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs failed.

Built with commit 9946683

https://app.netlify.com/sites/ru-reactjs/deploys/5c6ee83c16a791000831f0b9

@another-guyanother-guy mentioned this pull request Feb 21, 2019
Merged
@lex111
lex111 deleted the dont-call-proptypes branch February 28, 2019 00:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@gcorgcorgcor left review comments
@another-guyanother-guyanother-guy approved these changes
@ntishkevichntishkevichntishkevich left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lex111@gcor@another-guy@ntishkevich