Skip to content

Translate "Invalid Hook Call Warning" - #145

Merged
lex111 merged 7 commits into
masterfrom
invalid-hook-call-warning
Feb 20, 2019
Merged

Translate "Invalid Hook Call Warning"#145
lex111 merged 7 commits into
masterfrom
invalid-hook-call-warning

Conversation

@lex111

Copy link
Copy Markdown
Contributor

No description provided.

@lex111lex111 added the needs review A pull request ready to be reviewed label Feb 15, 2019
@tesseralistesseralis mentioned this pull request Feb 15, 2019
88 tasks
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
angryermineand others added 3 commits February 15, 2019 12:11
Co-Authored-By: lex111 <lex61rus@gmail.com>
Co-Authored-By: lex111 <lex61rus@gmail.com>
Co-Authored-By: lex111 <lex61rus@gmail.com>
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Co-Authored-By: lex111 <lex61rus@gmail.com>
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated

@doasyncdoasync left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предлагаю некоторые изменения

Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
Comment threadcontent/warnings/invalid-hook-call-warning.md Outdated
@another-guyanother-guy self-assigned this Feb 17, 2019
@lex111

Copy link
Copy Markdown
ContributorAuthor

Спасибо @gcor и @doasync за обзор.

@another-guyanother-guy removed their assignment Feb 20, 2019
@another-guyanother-guy removed the needs review A pull request ready to be reviewed label Feb 20, 2019
@another-guy

Copy link
Copy Markdown
Contributor

@lex1114fde03a поломал CircleCI build. В чём необходимость этих добавленных кавычек?

@lex111

Copy link
Copy Markdown
ContributorAuthor

@lex111 наоборот, исправил, а поломанный билд из-за того, что есть нарушения оформления кода в других файлах — это уже исправлено, поэтому можно сливать.

@lex111
lex111 merged commit b3975ee into masterFeb 20, 2019
@lex111
lex111 deleted the invalid-hook-call-warning branch February 20, 2019 10:52
@lex111

Copy link
Copy Markdown
ContributorAuthor

Спасибо за ревью @lfedorov, @gcor, @doasync и @another-guy.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@lex111@another-guy@angryermine@gcor@doasync