Skip to content

Translate "How to Contribute" (how-to-contribute.md) - #149

Merged
lex111 merged 43 commits into
reactjs:masterfrom
AlLevykin:AlLevykin-how-to-contribute
Feb 27, 2019
Merged

Translate "How to Contribute" (how-to-contribute.md)#149
lex111 merged 43 commits into
reactjs:masterfrom
AlLevykin:AlLevykin-how-to-contribute

Conversation

@AlLevykin

@AlLevykinAlLevykin commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

No description provided.

lex111
lex111 reviewed Feb 15, 2019
View reviewed changes
Comment threadcontent/docs/how-to-contribute.md Outdated
lex111
lex111 reviewed Feb 15, 2019
View reviewed changes
Comment threadcontent/docs/how-to-contribute.md Outdated
@lex111lex111 added the needs review A pull request ready to be reviewed label Feb 15, 2019
gcor
gcor reviewed Feb 15, 2019
View reviewed changes
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
gcorand others added 3 commits February 16, 2019 01:14
@gcor@AlLevykin
Update content/docs/how-to-contribute.md
30fe4e5
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@gcor@AlLevykin
Update content/docs/how-to-contribute.md
16bf2a3
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@AlLevykin
Update how-to-contribute.md
9e4c770
ntishkevich
ntishkevich reviewed Feb 16, 2019
View reviewed changes
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
ntishkevichand others added 3 commits February 16, 2019 15:20
@ntishkevich@AlLevykin
Update content/docs/how-to-contribute.md
2cf012e
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@ntishkevich@AlLevykin
Update content/docs/how-to-contribute.md
56a43b6
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@ntishkevich@AlLevykin
Update content/docs/how-to-contribute.md
83d08ce
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@tesseralistesseralis mentioned this pull request Feb 16, 2019
Closed
88 tasks
angryermine
angryermine reviewed Feb 17, 2019
View reviewed changes

@angryermineangryermine left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет! Предлагаю не изменять количество букв в слове pull, раз уж мы используем транслитерацию.

Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
angryermineand others added 3 commits February 17, 2019 16:23
@angryermine@AlLevykin
Update content/docs/how-to-contribute.md
bda6763
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@angryermine@AlLevykin
Update content/docs/how-to-contribute.md
c07e171
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@angryermine@AlLevykin
Update content/docs/how-to-contribute.md
8c4df63
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
angryermine
angryermine reviewed Feb 17, 2019
View reviewed changes
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
@lex111

lex111 commented Feb 17, 2019

Copy link
Copy Markdown
Contributor

@lfedorov мы используем словарь Веб-стандартов, и там pull request переводится с одной "л"

@angryermine

angryermine commented Feb 17, 2019

Copy link
Copy Markdown
Contributor

Прошу прощения, почему-то пропустил этот момент

@AlLevykin

AlLevykin commented Feb 17, 2019

Copy link
Copy Markdown
ContributorAuthor

Ну и Гитхаб аналогично https://github.com/web-standards-ru/dictionary/blob/master/git.md#g

@lex111

lex111 commented Feb 17, 2019

Copy link
Copy Markdown
Contributor

@AlLevykin не совсем так, поскольку мы для этого ввели правило:

Не переводите наименования компаний (Facebook, Airbnb), библиотек (Jest, Enzyme) и т.д.

Название ветки тоже не нужно переводить.

@angryermine

angryermine commented Feb 17, 2019

Copy link
Copy Markdown
Contributor

Почистил ревью от лишних изменений.

angryermineand others added 6 commits February 17, 2019 17:46
@angryermine@AlLevykin
Update content/docs/how-to-contribute.md
bb599ef
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@angryermine@AlLevykin
Update content/docs/how-to-contribute.md
ccc370e
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@angryermine@AlLevykin
Update content/docs/how-to-contribute.md
47b81f2
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@angryermine@AlLevykin
Update content/docs/how-to-contribute.md
dce5f31
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@angryermine@AlLevykin
Update content/docs/how-to-contribute.md
24208a3
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@angryermine@AlLevykin
Update content/docs/how-to-contribute.md
2226bcf
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@netlify

netlifyBot commented Feb 24, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 3e7482e

https://deploy-preview-149--ru-reactjs.netlify.com

another-guy
another-guy suggested changes Feb 25, 2019
View reviewed changes

@another-guyanother-guy left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Есть кое-какие советы по улучшению. В целом, уже читается очень неплохо ! Спасибо, @AlLevykin 👍

Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
Comment threadcontent/docs/how-to-contribute.md Outdated
@another-guyanother-guy added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 25, 2019
another-guyand others added 14 commits February 25, 2019 18:45
@another-guy@AlLevykin
Update content/docs/how-to-contribute.md
92c51ed
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@another-guy@AlLevykin
Update content/docs/how-to-contribute.md
4081a35
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@another-guy@AlLevykin
Update content/docs/how-to-contribute.md
4d034f8
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@another-guy@AlLevykin
Update content/docs/how-to-contribute.md
4788f67
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@another-guy@AlLevykin
Update content/docs/how-to-contribute.md
e07e704
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@another-guy@AlLevykin
Update content/docs/how-to-contribute.md
19ea2df
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@another-guy@AlLevykin
Update content/docs/how-to-contribute.md
bca73f0
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@another-guy@AlLevykin
Update content/docs/how-to-contribute.md
c68a0fe
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@another-guy@AlLevykin
Update content/docs/how-to-contribute.md
5f90b24
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@another-guy@AlLevykin
Update content/docs/how-to-contribute.md
4c9609d
Co-Authored-By: AlLevykin <a.a.levykin@gmail.com>
@AlLevykin
Update 2015-03-30-community-roundup-26.md
b1c134e
@AlLevykin
Update how-to-contribute.md
2a8b272
@AlLevykin
Revert "Update 2015-03-30-community-roundup-26.md"
03d6be5
This reverts commit b1c134e.
@AlLevykin
Update how-to-contribute.md
33e01e9
@another-guy

another-guy commented Feb 25, 2019

Copy link
Copy Markdown
Contributor

@AlLevykin исправь, пожалуйста, merge conflict. Спасибо за внесение изменений.

lex111
lex111 approved these changes Feb 27, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Внёс непосредственно свои правки, если что исправим/улучшим в отдельных в PR.

@lex111
lex111 merged commit 8161fb8 into reactjs:masterFeb 27, 2019
@lex111

lex111 commented Feb 27, 2019

Copy link
Copy Markdown
Contributor

Спасибо @AlLevykin, а также @lfedorov, @gcor, @ntishkevich и @another-guy за ревью! 🎉

@lex111lex111 added needs proofread A read-through is still needed to release the document and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers
@angryermineangryermineangryermine left review comments
@gcorgcorgcor left review comments
@ntishkevichntishkevichntishkevich left review comments
@lex111lex111lex111 approved these changes
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AlLevykin@lex111@angryermine@another-guy@gcor@ntishkevich