Skip to content

Интеграция со сторонними библиотеками - #159

Merged
lex111 merged 53 commits into
reactjs:masterfrom
vvscode:integrating-with-other-libraries
Feb 23, 2019
Merged

Интеграция со сторонними библиотеками#159
lex111 merged 53 commits into
reactjs:masterfrom
vvscode:integrating-with-other-libraries

Conversation

@vvscode

@vvscodevvscode commented Feb 17, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@lex111lex111 added the needs review A pull request ready to be reviewed label Feb 17, 2019
lex111
lex111 reviewed Feb 17, 2019
View reviewed changes
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
@tesseralistesseralis mentioned this pull request Feb 18, 2019
Closed
88 tasks
lex111and others added 18 commits February 18, 2019 08:25
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
9ed720c
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
2d16c85
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@vvscode
Restore title/id
e2354a1
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
eaeece8
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
9444251
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
c4a106d
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
4d581df
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@vvscode
Открыть / посмотреть
75e89e8
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
0610f82
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
6170b35
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
32da31c
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
ddc5cd5
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
952c1b3
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
e8ee62e
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
7e9631e
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
4e4de93
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
c4df408
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Apply suggestions from code review
c8381ba
Co-Authored-By: vvscode <v.vanchuk@tut.by>
ntishkevich
ntishkevich reviewed Feb 18, 2019
View reviewed changes
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
ntishkevichand others added 5 commits February 19, 2019 03:25
@ntishkevich@vvscode
Update content/docs/integrating-with-other-libraries.md
3bc6630
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@ntishkevich@vvscode
Apply suggestions from code review
b95f122
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
51fef63
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
25935dd
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@vvscode
Fix notice from codereview
dc5a38a
lex111
lex111 reviewed Feb 19, 2019
View reviewed changes
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
@lex111@vvscode
Update content/docs/integrating-with-other-libraries.md
a81e2a1
Co-Authored-By: vvscode <v.vanchuk@tut.by>
another-guy
another-guy suggested changes Feb 22, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Несколько замечаний по стилю, опечатки, и пара более серьезных вещей.
Спасибо за проделанную работу @vvscode!!! 👍

Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
Comment threadcontent/docs/integrating-with-other-libraries.md Outdated
@another-guyanother-guy removed their assignment Feb 22, 2019
another-guyand others added 9 commits February 22, 2019 19:18
@another-guy@vvscode
Update content/docs/integrating-with-other-libraries.md
af56253
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@another-guy@vvscode
Update content/docs/integrating-with-other-libraries.md
7ea7cd0
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@another-guy@vvscode
Update content/docs/integrating-with-other-libraries.md
9be8075
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@another-guy@vvscode
Update content/docs/integrating-with-other-libraries.md
8a41f04
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@another-guy@vvscode
Update content/docs/integrating-with-other-libraries.md
1586594
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@another-guy@vvscode
Update content/docs/integrating-with-other-libraries.md
1db5c91
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@another-guy@vvscode
Update content/docs/integrating-with-other-libraries.md
187b668
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@another-guy@vvscode
Update content/docs/integrating-with-other-libraries.md
5189390
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@another-guy@vvscode
Update content/docs/integrating-with-other-libraries.md
12f6391
Co-Authored-By: vvscode <v.vanchuk@tut.by>
@netlify

netlifyBot commented Feb 22, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit af56253

https://deploy-preview-159--ru-reactjs.netlify.com

@netlify

netlifyBot commented Feb 22, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 12f6391

https://deploy-preview-159--ru-reactjs.netlify.com

@netlify

netlifyBot commented Feb 22, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 2da81e9

https://deploy-preview-159--ru-reactjs.netlify.com

another-guy
another-guy approved these changes Feb 22, 2019
View reviewed changes

@another-guyanother-guy left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 @vvscode 👍

P.S. Пожалуйста, исправь конфликт мёрджа.

@another-guyanother-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Feb 22, 2019
@lex111
lex111 merged commit 9d128e2 into reactjs:masterFeb 23, 2019
@lex111

lex111 commented Feb 23, 2019

Copy link
Copy Markdown
Contributor

@vvscode спасибо, а также @ntishkevich и @another-guy за ревью!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@lex111lex111lex111 approved these changes
@ntishkevichntishkevichntishkevich left review comments
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vvscode@lex111@another-guy@ntishkevich