Skip to content

Context translation (ready) - #164

Merged
another-guy merged 26 commits into
reactjs:masterfrom
egorzekov:context-translation
Mar 1, 2019
Merged

Context translation (ready)#164
another-guy merged 26 commits into
reactjs:masterfrom
egorzekov:context-translation

Conversation

@egorzekov

@egorzekovegorzekov commented Feb 18, 2019

Copy link
Copy Markdown
Contributor

Коллеги, обратите внимание, что изменения в следующих файлах - результат того, что кто-то не запускал yarn check-all перед пул-реквестом:

modified: gatsby-config.js
modified: src/components/CodeEditor/CodeEditor.js
modified: src/components/ErrorDecoder/ErrorDecoder.js
modified: src/components/LayoutFooter/Footer.js
modified: src/components/TitleAndMetaTags/TitleAndMetaTags.js
modified: src/pages/index.js

@tesseralistesseralis mentioned this pull request Feb 18, 2019
Closed
88 tasks
ntishkevich
ntishkevich reviewed Feb 18, 2019
View reviewed changes

@ntishkevichntishkevich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lex111@another-guy@gaearon
Также есть вопрос об использовании «...» в примерах вместо "..." ? Если стоит, то необходимо будет изменить тип кавычек в этом PRе

Comment threadcontent/docs/context.md Outdated
Comment threadcontent/docs/context.md Outdated
Comment threadcontent/docs/context.md Outdated
Comment threadcontent/docs/context.md Outdated
Comment threadcontent/docs/context.md Outdated
Comment threadcontent/docs/context.md Outdated
gcor
gcor reviewed Feb 18, 2019
View reviewed changes
Comment threadcontent/docs/context.md Outdated
Comment threadcontent/docs/context.md Outdated
Comment threadcontent/docs/context.md Outdated
Comment threadcontent/docs/context.md Outdated
Comment threadcontent/docs/context.md Outdated
Comment threadcontent/docs/context.md Outdated
Comment threadcontent/docs/context.md Outdated
lex111
lex111 reviewed Feb 18, 2019
View reviewed changes
Comment threadcontent/docs/context.md Outdated
lex111
lex111 reviewed Feb 18, 2019
View reviewed changes
Comment threadcontent/docs/context.md
@lex111

lex111 commented Feb 18, 2019

Copy link
Copy Markdown
Contributor

@egorzekov отдельное спасибо за напоминание про команду, я сделал коммит сразу в мастер с исправлениями, чтобы в PR были только файлы, которые относятся к переводу.

@lex111

lex111 commented Feb 18, 2019

Copy link
Copy Markdown
Contributor

Подключил CI, теперь будем в курсе подобных ошибок 🤖

@lex111lex111 added the needs review A pull request ready to be reviewed label Feb 18, 2019
lex111
lex111 reviewed Feb 19, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Улучшения по коду.

Comment threadexamples/context/motivation-problem.js Outdated
Comment threadexamples/context/motivation-problem.js Outdated
Comment threadexamples/context/motivation-problem.js Outdated
Comment threadexamples/context/motivation-solution.js Outdated
Comment threadexamples/context/updating-nested-context-app.js Outdated
Comment threadexamples/context/updating-nested-context-theme-toggler-button.js Outdated
lex111and others added 20 commits February 19, 2019 17:15
@lex111@egorzekov
Update examples/context/updating-nested-context-theme-toggler-button.js
25afe93
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@lex111@egorzekov
Update examples/context/motivation-problem.js
b7bfe93
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@lex111@egorzekov
Update content/docs/context.md
6845659
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@lex111@egorzekov
Update examples/context/motivation-problem.js
265983b
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@lex111@egorzekov
Update examples/context/updating-nested-context-app.js
2de5d65
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@lex111@egorzekov
Update examples/context/motivation-problem.js
a278a59
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@lex111@egorzekov
Update examples/context/motivation-solution.js
82196f9
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor@egorzekov
Update content/docs/context.md
8b4e287
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor@egorzekov
Update content/docs/context.md
a1ef811
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor@egorzekov
Update content/docs/context.md
e905805
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor@egorzekov
Update content/docs/context.md
f7630aa
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor@egorzekov
Update content/docs/context.md
6b9da8e
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@ntishkevich@egorzekov
Update content/docs/context.md
32f49fd
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@ntishkevich@egorzekov
Update content/docs/context.md
59bd18a
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor@egorzekov
Update content/docs/context.md
07085a2
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@gcor@egorzekov
Update content/docs/context.md
d56693a
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@ntishkevich@egorzekov
Update content/docs/context.md
11a023f
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@ntishkevich@egorzekov
Update content/docs/context.md
92e2f55
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@ntishkevich@egorzekov
Update content/docs/context.md
6e56a57
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@ntishkevich@egorzekov
Update content/docs/context.md
cb1a474
Co-Authored-By: egorzekov <egorzekov@gmail.com>
@netlify

netlifyBot commented Feb 21, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ru-reactjs failed.

Built with commit 2286f2d

https://app.netlify.com/sites/ru-reactjs/deploys/5c79a51589adb7000a2dc2b2

angryermine
angryermine reviewed Feb 27, 2019
View reviewed changes
Comment threadexamples/context/multiple-contexts.js Outdated
SmolinPavel
SmolinPavel reviewed Feb 28, 2019
View reviewed changes
Comment threadcontent/docs/context.md
@another-guyanother-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Mar 1, 2019
@another-guy
another-guy merged commit b16ec10 into reactjs:masterMar 1, 2019
@another-guy

another-guy commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

Спасибо за перевод и фиксы, @egorzekov! 💯

@another-guyanother-guy removed their assignment Mar 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

6 more reviewers
@angryermineangryermineangryermine left review comments
@lex111lex111lex111 left review comments
@gcorgcorgcor left review comments
@ntishkevichntishkevichntishkevich left review comments
@SmolinPavelSmolinPavelSmolinPavel left review comments
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@egorzekov@lex111@another-guy@angryermine@gcor@ntishkevich@SmolinPavel