Skip to content

Translate Higher Order Components - #167

Merged
another-guy merged 11 commits into
reactjs:masterfrom
agoldis:hoc-translation
Feb 22, 2019
Merged

Translate Higher Order Components#167
another-guy merged 11 commits into
reactjs:masterfrom
agoldis:hoc-translation

Conversation

@agoldis

@agoldisagoldis commented Feb 19, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@agoldis
Translate HOC
ccb9f2f
@agoldis
Merge remote-tracking branch 'upstream/master' into hoc-translation
b237d54
* upstream/master: (103 commits)
Fixes
Fix title in refs-must-have-owner.md
Убрал остатки испанского из очень плохого примера
fix broken audio link in community roundup 26
updated footer to get year based on current date
README.md: fix link
Fixes after review
Update content/docs/hooks-intro.md
Update content/docs/hooks-intro.md
Update content/docs/hooks-intro.md
Update content/docs/hooks-intro.md
Update content/docs/hooks-intro.md
Update content/docs/hooks-intro.md
Update content/docs/hooks-intro.md
Терминология: codemod
Update content/docs/hooks-intro.md
Translate MarkdownPage component
Терминология: хук
Терминология: TLDR
Update hooks-intro.md
...
@agoldis
Add nav translation for HOC
22bedb3
@tesseralistesseralis mentioned this pull request Feb 19, 2019
Closed
88 tasks
@lex111lex111 added the needs review A pull request ready to be reviewed label Feb 19, 2019
lex111
lex111 reviewed Feb 19, 2019
View reviewed changes
Comment threadcontent/docs/higher-order-components.md Outdated
angryermine
angryermine reviewed Feb 19, 2019
View reviewed changes
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
@angryermine@agoldis
Apply suggestions from code review
9029364
Co-Authored-By: agoldis <agoldis@users.noreply.github.com>
@agoldis

agoldis commented Feb 19, 2019

Copy link
Copy Markdown
ContributorAuthor

@lfedorov огромное спасибо за исправления! 👏🏻🍻

lex111
lex111 reviewed Feb 20, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом, неплохо! 👌 Есть ещё над чем поработать, пока нашёл то, что явно бросается в глаза.

Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
@lex111@agoldis
Apply suggestions from code review by@lex111
8dbb09e
Co-Authored-By: agoldis <agoldis@users.noreply.github.com>
@another-guyanother-guy mentioned this pull request Feb 20, 2019
Merged
1 task
@another-guyanother-guy self-assigned this Feb 20, 2019
another-guy
another-guy suggested changes Feb 21, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Несколько поправок не хватает для аппрува.

В целом же, читается хорошо. Спасибо за перевод 🎉 🎉

Comment threadTRANSLATION.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
Comment threadcontent/docs/higher-order-components.md Outdated
@another-guyanother-guy removed their assignment Feb 21, 2019
@another-guy@agoldis
Apply suggestions from code review by@another-guy
9a4f20a
Co-Authored-By: agoldis <agoldis@users.noreply.github.com>
@netlify

netlifyBot commented Feb 21, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 9a4f20a

https://deploy-preview-167--ru-reactjs.netlify.com

@another-guy@agoldis
Update mixin term
24b0bd2
Co-Authored-By: agoldis <agoldis@users.noreply.github.com>
@netlify

netlifyBot commented Feb 22, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 9a4f20a

https://deploy-preview-167--ru-reactjs.netlify.com

@netlify

netlifyBot commented Feb 22, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 6323e57

https://deploy-preview-167--ru-reactjs.netlify.com

another-guy
another-guy approved these changes Feb 22, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agoldis если не трудно, поправь на отображаемОЕ имя, как посоветовал Алексей. Этот вариант самый лучший.

Аппрув 🎉 🎉 🎉

@agoldis

agoldis commented Feb 22, 2019

Copy link
Copy Markdown
ContributorAuthor

@another-guy все исправил! Спасибо за помощь!

@another-guyanother-guy removed the needs review A pull request ready to be reviewed label Feb 22, 2019
@another-guy
another-guy merged commit f5d865f into reactjs:masterFeb 22, 2019
@another-guyanother-guy added the needs proofread A read-through is still needed to release the document label Feb 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@angryermineangryermineangryermine left review comments
@lex111lex111lex111 left review comments
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agoldis@angryermine@lex111@another-guy