Skip to content

Jsx in depth - #206

Merged
lex111 merged 6 commits into
reactjs:masterfrom
RenatRysaev:jsx-in-depth
Mar 5, 2019
Merged

Jsx in depth#206
lex111 merged 6 commits into
reactjs:masterfrom
RenatRysaev:jsx-in-depth

Conversation

@RenatRysaev

@RenatRysaevRenatRysaev commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@netlify

netlifyBot commented Mar 1, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 876fafc

https://deploy-preview-206--ru-reactjs.netlify.com

@RenatRysaevRenatRysaev mentioned this pull request Mar 1, 2019
Closed
88 tasks
@gcorgcor added the needs review A pull request ready to be reviewed label Mar 1, 2019
angryermine
angryermine reviewed Mar 1, 2019
View reviewed changes
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
ntishkevich
ntishkevich reviewed Mar 1, 2019
View reviewed changes
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
lex111
lex111 reviewed Mar 1, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предложения для улучшения перевода.

Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
another-guy
another-guy suggested changes Mar 2, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Перевод хороший. Я постарался убрать повторяющиеся слова и частые вводные конструкции. Местами мелкие опечатки и пунктуационные неточности.

@RenatRysaev спасибо за работу над очередным переводом !!! 👍

Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
@another-guyanother-guy added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Mar 2, 2019
gcor
gcor reviewed Mar 3, 2019
View reviewed changes
Comment threadcontent/docs/jsx-in-depth.md Outdated
gcor
gcor reviewed Mar 3, 2019
View reviewed changes
Comment threadcontent/docs/jsx-in-depth.md Outdated
gcor
gcor reviewed Mar 3, 2019
View reviewed changes

@gcorgcor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Попробовал упростить некоторые места

Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
Comment threadcontent/docs/jsx-in-depth.md Outdated
another-guy
another-guy approved these changes Mar 4, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcor спасибо за дополнительный проход по тексту!

ntishkevich
ntishkevich reviewed Mar 4, 2019
View reviewed changes
Comment threadcontent/docs/jsx-in-depth.md Outdated
@lex111

lex111 commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

@RenatRysaev вы можете, пожалуйста, принять предложенные правки?

@RenatRysaev

RenatRysaev commented Mar 5, 2019

Copy link
Copy Markdown
ContributorAuthor

@RenatRysaev вы можете, пожалуйста, принять предложенные правки?

@lex111, да, сегодня закомичу

@lex111
lex111 merged commit e0876b4 into reactjs:masterMar 5, 2019
@lex111

lex111 commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

Спасибо @RenatRysaev за перевод, а также @lfedorov, @ntishkevich, @another-guy и @gcor за ревью!

P.S. Внёс свои корректировки, в основном перевод в примерах кода.

@lex111lex111 added needs proofread A read-through is still needed to release the document and removed work in progress Author opened the pull-request but it's still being worked on labels Mar 5, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers
@angryermineangryermineangryermine left review comments
@gcorgcorgcor left review comments
@another-guyanother-guyanother-guy approved these changes
@ntishkevichntishkevichntishkevich left review comments
@lex111lex111lex111 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RenatRysaev@lex111@angryermine@gcor@another-guy@ntishkevich