Skip to content

composition-vs-inheritance.md - #225

Merged
lex111 merged 9 commits into
reactjs:masterfrom
gcor:composition-vs-inheritance
Mar 10, 2019
Merged

composition-vs-inheritance.md#225
lex111 merged 9 commits into
reactjs:masterfrom
gcor:composition-vs-inheritance

Conversation

@gcor

@gcorgcor commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@gcor
gcorforce-pushed the composition-vs-inheritance branch from 5736680 to c0be4e5CompareMarch 4, 2019 20:18
@netlify

netlifyBot commented Mar 4, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 5736680

https://deploy-preview-225--ru-reactjs.netlify.com

@gcorgcor added the needs review A pull request ready to be reviewed label Mar 4, 2019
@netlify

netlifyBot commented Mar 4, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 5b071d6

https://deploy-preview-225--ru-reactjs.netlify.com

@gcor
gcorforce-pushed the composition-vs-inheritance branch from 140284b to 9ca6dc6CompareMarch 4, 2019 20:51
ntishkevich
ntishkevich reviewed Mar 4, 2019
View reviewed changes
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
@ntishkevich@gcor
Update content/docs/composition-vs-inheritance.md
26f761f
Co-Authored-By: gcor <anton@gcor.ru>
@lex111lex111 mentioned this pull request Mar 4, 2019
Closed
88 tasks
another-guy
another-guy reviewed Mar 5, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Небольшие советы по улучшению читаемости.

@gcor спасибо за оперативный перевод! 💯

Comment threadcontent/docs/composition-vs-inheritance.md Outdated
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
Comment threadcontent/docs/composition-vs-inheritance.md Outdated
@another-guy
another-guy requested a review from lex111March 6, 2019 01:50
@another-guy

another-guy commented Mar 6, 2019

Copy link
Copy Markdown
Contributor

@lex111 посмотри пожалуйста, как будет время. Тут не такой большой материал.

lex111
lex111 approved these changes Mar 10, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Жаль, что @aamorozov не присоединился к этому переводу, я его ждал, но ладно. Внёс небольшие поправки, теперь можем сливать.

@lex111
lex111 merged commit 1734526 into reactjs:masterMar 10, 2019
@lex111

lex111 commented Mar 10, 2019

Copy link
Copy Markdown
Contributor

Спасибо @gcor за оперативный перевод! А также @ntishkevich и @another-guy за ревью!

@another-guyanother-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Mar 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@ntishkevichntishkevichntishkevich left review comments
@lex111lex111lex111 approved these changes
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gcor@another-guy@lex111@ntishkevich