Skip to content

Translation design principles pt2 - #258

Merged
another-guy merged 34 commits into
reactjs:masterfrom
echobrain:translation-design-principles-pt2
Mar 21, 2019
Merged

Translation design principles pt2#258
another-guy merged 34 commits into
reactjs:masterfrom
echobrain:translation-design-principles-pt2

Conversation

@echobrain

@echobrainechobrain commented Mar 13, 2019

Copy link
Copy Markdown
Contributor

Вторая часть перевода

@echobrainechobrain mentioned this pull request Mar 13, 2019
Closed
88 tasks
@netlify

netlifyBot commented Mar 13, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit b940113

https://deploy-preview-258--ru-reactjs.netlify.com

@echobrainechobrain changed the title translation pt2Translation design principles pt2Mar 13, 2019
@ntishkevichntishkevich added the needs review A pull request ready to be reviewed label Mar 13, 2019
angryermine
angryermine reviewed Mar 14, 2019
View reviewed changes
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
angryermineand others added 5 commits March 14, 2019 20:18
@angryermine@echobrain
Update content/docs/design-principles.md
658180a
Co-Authored-By: echobrain <gostevim@gmail.com>
@angryermine@echobrain
Update content/docs/design-principles.md
e904158
Co-Authored-By: echobrain <gostevim@gmail.com>
@angryermine@echobrain
Update content/docs/design-principles.md
510ec6b
Co-Authored-By: echobrain <gostevim@gmail.com>
@angryermine@echobrain
Update content/docs/design-principles.md
196acc6
Co-Authored-By: echobrain <gostevim@gmail.com>
@angryermine@echobrain
Update content/docs/design-principles.md
5081eda
Co-Authored-By: echobrain <gostevim@gmail.com>
ntishkevich
ntishkevich reviewed Mar 14, 2019
View reviewed changes
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
@another-guyanother-guy self-assigned this Mar 15, 2019
ntishkevichand others added 6 commits March 15, 2019 08:50
@ntishkevich@echobrain
Update content/docs/design-principles.md
af00968
Co-Authored-By: echobrain <gostevim@gmail.com>
@ntishkevich@echobrain
Update content/docs/design-principles.md
4b1e0fa
Co-Authored-By: echobrain <gostevim@gmail.com>
@ntishkevich@echobrain
Update content/docs/design-principles.md
e68e47d
Co-Authored-By: echobrain <gostevim@gmail.com>
@ntishkevich@echobrain
Update content/docs/design-principles.md
91038c2
Co-Authored-By: echobrain <gostevim@gmail.com>
@ntishkevich@echobrain
Update content/docs/design-principles.md
1ba8199
Co-Authored-By: echobrain <gostevim@gmail.com>
@ntishkevich@echobrain
Update content/docs/design-principles.md
e26b03e
Co-Authored-By: echobrain <gostevim@gmail.com>
gcor
gcor reviewed Mar 15, 2019
View reviewed changes
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
gcorand others added 10 commits March 15, 2019 10:44
@gcor@echobrain
Update content/docs/design-principles.md
32eb0fd
Co-Authored-By: echobrain <gostevim@gmail.com>
@gcor@echobrain
Update content/docs/design-principles.md
f1f3209
Co-Authored-By: echobrain <gostevim@gmail.com>
@ntishkevich@echobrain
Update content/docs/design-principles.md
51ec6ba
Co-Authored-By: echobrain <gostevim@gmail.com>
@gcor@echobrain
Update content/docs/design-principles.md
be4405b
Co-Authored-By: echobrain <gostevim@gmail.com>
@gcor@echobrain
Update content/docs/design-principles.md
2c4d534
Co-Authored-By: echobrain <gostevim@gmail.com>
@gcor@echobrain
Update content/docs/design-principles.md
fbef33e
Co-Authored-By: echobrain <gostevim@gmail.com>
@gcor@echobrain
Update content/docs/design-principles.md
e21f96a
Co-Authored-By: echobrain <gostevim@gmail.com>
@gcor@echobrain
Update content/docs/design-principles.md
c9642f1
Co-Authored-By: echobrain <gostevim@gmail.com>
@echobrain
fixed translation of debugging
52a3167
@another-guy
Update design-principles.md
a2f8c3f
another-guy
another-guy reviewed Mar 19, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echobrain спасибо за перевод!! 👍 👍 👍 Вот несколько замечаний и предложений.

Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
Comment threadcontent/docs/design-principles.md Outdated
@another-guyanother-guy removed their assignment Mar 19, 2019
@another-guyanother-guy added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Mar 19, 2019
angryermine
angryermine reviewed Mar 19, 2019
View reviewed changes
Comment threadcontent/docs/design-principles.md Outdated
another-guyand others added 12 commits March 20, 2019 11:34
@another-guy@echobrain
Update content/docs/design-principles.md
b14149b
Co-Authored-By: echobrain <gostevim@gmail.com>
@another-guy@echobrain
Update content/docs/design-principles.md
d683265
Co-Authored-By: echobrain <gostevim@gmail.com>
@another-guy@echobrain
Update content/docs/design-principles.md
929ad2c
Co-Authored-By: echobrain <gostevim@gmail.com>
@another-guy@echobrain
Update content/docs/design-principles.md
5555b9e
Co-Authored-By: echobrain <gostevim@gmail.com>
@another-guy@echobrain
Update content/docs/design-principles.md
1a66615
Co-Authored-By: echobrain <gostevim@gmail.com>
@another-guy@echobrain
Update content/docs/design-principles.md
1546833
Co-Authored-By: echobrain <gostevim@gmail.com>
@another-guy@echobrain
Update content/docs/design-principles.md
656319a
Co-Authored-By: echobrain <gostevim@gmail.com>
@angryermine@echobrain
Update content/docs/design-principles.md
b5dceb0
Co-Authored-By: echobrain <gostevim@gmail.com>
@another-guy@echobrain
Update content/docs/design-principles.md
1d2e7c4
Co-Authored-By: echobrain <gostevim@gmail.com>
@another-guy@echobrain
Update content/docs/design-principles.md
b4c28ac
Co-Authored-By: echobrain <gostevim@gmail.com>
@another-guy@echobrain
Update content/docs/design-principles.md
0c55e0e
Co-Authored-By: echobrain <gostevim@gmail.com>
@another-guy@echobrain
Update content/docs/design-principles.md
b940113
Co-Authored-By: echobrain <gostevim@gmail.com>
@another-guyanother-guy removed the work in progress Author opened the pull-request but it's still being worked on label Mar 21, 2019
@another-guy
another-guy merged commit 2fdc141 into reactjs:masterMar 21, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@angryermineangryermineangryermine left review comments
@gcorgcorgcor left review comments
@ntishkevichntishkevichntishkevich left review comments
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@echobrain@angryermine@gcor@another-guy@ntishkevich