Skip to content

Translate React Element Factories and JSX Warning - #31

Merged
lex111 merged 2 commits into
masterfrom
legacy-factories
Feb 10, 2019
Merged

Translate React Element Factories and JSX Warning#31
lex111 merged 2 commits into
masterfrom
legacy-factories

Conversation

@lex111

@lex111lex111 commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

Перенёс перевод без изменений из Crowdin - https://crowdin.com/translate/react/1042/en-ru

  • требуется рассмотреть согласование перевода In Depth и занести в словарь.

@lex111lex111 added work in progress Author opened the pull-request but it's still being worked on from-crowdin This translation came from Crowdin labels Feb 9, 2019
@lex111

lex111 commented Feb 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Эта страница вообще используется, её не нашёл в прогрессе?

@gaearon

gaearon commented Feb 10, 2019•
edited by lex111
Loading

Copy link
Copy Markdown
Member

@tesseralis Any reason this page is missing in the template?

@tesseralis

tesseralis commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

I must have forgot it 😓I'll add it and update all the issues

gaearon
gaearon approved these changes Feb 10, 2019
View reviewed changes

@gaearongaearon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks

Comment threadcontent/warnings/legacy-factories.md Outdated
Comment threadcontent/warnings/legacy-factories.md Outdated
Comment threadcontent/warnings/legacy-factories.md Outdated
@tesseralis

tesseralis commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

@gaearon Fixed. I misnamed it "legacy-properties" instead!

@lex111lex111 added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 10, 2019
@lex111
lex111 merged commit cace61d into masterFeb 10, 2019
@lex111
lex111 deleted the legacy-factories branch February 10, 2019 01:12
@tesseralistesseralis mentioned this pull request Feb 10, 2019
Closed
88 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearongaearongaearon approved these changes

Assignees

No one assigned

Labels

from-crowdinThis translation came from Crowdinneeds reviewA pull request ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lex111@gaearon@tesseralis