Skip to content

Translate FAQ Component State - #36

Merged
lex111 merged 4 commits into
reactjs:masterfrom
Nadjakoroleva:Nadjakoroleva-patch-1
Feb 27, 2019
Merged

Translate FAQ Component State#36
lex111 merged 4 commits into
reactjs:masterfrom
Nadjakoroleva:Nadjakoroleva-patch-1

Conversation

@Nadjakoroleva

@NadjakorolevaNadjakoroleva commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@NadjakorolevaNadjakoroleva changed the title first verTranslate FAQ Component StateFeb 9, 2019
@tesseralistesseralis mentioned this pull request Feb 9, 2019
Closed
88 tasks
lex111
lex111 suggested changes Feb 9, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо! Комментарии после беглого обзора перевода, также ознакомтесь с руководством.

Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
@lex111lex111 added the needs review A pull request ready to be reviewed label Feb 9, 2019
another-guy
another-guy reviewed Feb 9, 2019
View reviewed changes
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
lex111
lex111 reviewed Feb 9, 2019
View reviewed changes
Comment threadcontent/docs/faq-state.md Outdated
@another-guy

another-guy commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

@Nadjakoroleva Неплохой старт! Пусть обилие замечаний не смущает. Подавляющее большинство из них -- "косметические" проблемы.

@Nadjakoroleva

Nadjakoroleva commented Feb 11, 2019

Copy link
Copy Markdown
ContributorAuthor

@Nadjakoroleva Неплохой старт! Пусть обилие замечаний не смущает. Подавляющее большинство из них -- "косметические" проблемы.

Спасибо большое за комментарии! В ближайшие пару дней исправлю

@another-guyanother-guy added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 12, 2019
@Nadjakoroleva

Nadjakoroleva commented Feb 13, 2019

Copy link
Copy Markdown
ContributorAuthor

Отправила обновленную версию

angryermine
angryermine reviewed Feb 17, 2019
View reviewed changes
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
Comment threadcontent/docs/faq-state.md Outdated
@lex111

lex111 commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

@Nadjakoroleva вы можете рассмотреть предложенные правки?

@netlify

netlifyBot commented Feb 27, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 600b9c4

https://deploy-preview-36--ru-reactjs.netlify.com

lex111
lex111 reviewed Feb 27, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поскольку пулревест долго уже "висит", то напрямую отредактировал перевод, приняв предолженные поправки.

@lex111
lex111 merged commit a1e6c6a into reactjs:masterFeb 27, 2019
@lex111

lex111 commented Feb 27, 2019

Copy link
Copy Markdown
Contributor

Спасибо @Nadjakoroleva, а также @lfedorov и @another-guy за ревью!

Остальные улучшения и прочие исправления в отдельных PR.

@lex111lex111 added needs proofread A read-through is still needed to release the document and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearongaearongaearon left review comments
+3 more reviewers
@angryermineangryermineangryermine left review comments
@another-guyanother-guyanother-guy left review comments
@lex111lex111lex111 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Nadjakoroleva@another-guy@lex111@gaearon@angryermine