Skip to content

Translate Is React Translated Yet? ¡Sí! Sim! はい！ blog post - #409

Merged
ntishkevich merged 7 commits into
reactjs:masterfrom
lyskos97:master
Oct 7, 2019
Merged

Translate Is React Translated Yet? ¡Sí! Sim! はい！ blog post#409
ntishkevich merged 7 commits into
reactjs:masterfrom
lyskos97:master

Conversation

@lyskos97

@lyskos97lyskos97 commented Oct 5, 2019

Copy link
Copy Markdown
Contributor

Если ваш пулреквест является исправлением бага, а не переводом, то сперва убедитесь, что проблема относится ТОЛЬКО к https://ru.reactjs.org, а не к https://reactjs.org. Если это не так, то пулреквест следует открыть в родительском репозитории.

@lyskos97

lyskos97 commented Oct 5, 2019

Copy link
Copy Markdown
ContributorAuthor

#273

@lyskos97
lyskos97 marked this pull request as ready for review October 5, 2019 20:31
@netlify

netlifyBot commented Oct 5, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit dfefa97

https://deploy-preview-409--ru-reactjs.netlify.com

lex111
lex111 suggested changes Oct 5, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Круто, хороший перевод! Некоторые улучшения и исправления.

Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
lyskos97and others added 2 commits October 6, 2019 10:55
@lyskos97@lex111
Apply suggestions from code review
2814c6f
* Fix typos and stylistics
Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
@lyskos97@lex111
Apply suggestions from code review (2)
a362178
Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
@lyskos97

lyskos97 commented Oct 6, 2019

Copy link
Copy Markdown
ContributorAuthor

@lex111, принял. Спасибо за ревью.
Хотел уточнить: как лучше переводить "contributor"/"contribution" и "maintainer"?

@lyskos97
lyskos97 requested a review from lex111October 6, 2019 05:30
@lex111

lex111 commented Oct 6, 2019

Copy link
Copy Markdown
Contributor

@lyskos97

maintainer -> мейнтейнер
contributor -> участник
contribution -> участие/вклад (в зависимости от контекста)

@lex111
lex111 requested a review from a teamOctober 6, 2019 10:55
gcor
gcor reviewed Oct 6, 2019
View reviewed changes

@gcorgcor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Спасибо за перевод. Несколько предложений)

Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
Comment threadcontent/blog/2019-02-23-is-react-translated-yet.md Outdated
@lyskos97@gcor
Apply suggestions from code review
dfefa97
Co-Authored-By: Anton Ahatov <anton@gcor.ru>
@lyskos97

lyskos97 commented Oct 6, 2019

Copy link
Copy Markdown
ContributorAuthor

@gcor, спасибо за ревью!

@lyskos97
lyskos97 requested a review from gcorOctober 6, 2019 14:38
gcor
gcor approved these changes Oct 6, 2019
View reviewed changes
@lex111

lex111 commented Oct 7, 2019

Copy link
Copy Markdown
Contributor

@ntishkevich сливай, если всё ок.

@ntishkevich

ntishkevich commented Oct 7, 2019

Copy link
Copy Markdown
Contributor

@lyskos97 Отличная работа! Спасибо за ваш перевод! 💪

@ntishkevich
ntishkevich merged commit 4fb0424 into reactjs:masterOct 7, 2019
@vvscodevvscode mentioned this pull request Oct 7, 2019
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@lex111lex111lex111 approved these changes
@gcorgcorgcor approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lyskos97@lex111@ntishkevich@gcor