Skip to content

Translate implementation notes - #433

Merged
gcor merged 9 commits into
reactjs:masterfrom
BogdanDor:implementation-notes-translate
Feb 10, 2020
Merged

Translate implementation notes#433
gcor merged 9 commits into
reactjs:masterfrom
BogdanDor:implementation-notes-translate

Conversation

@BogdanDor

@BogdanDorBogdanDor commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

Translate "Implementation notes".

@netlify

netlifyBot commented Nov 14, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit e2f7c9d

https://deploy-preview-433--ru-reactjs.netlify.com

@BogdanDorBogdanDor mentioned this pull request Nov 14, 2019
Closed
88 tasks
angryermine
angryermine reviewed Nov 20, 2019
View reviewed changes

@angryermineangryermine left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Опечатки

Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
@ntishkevichntishkevich added the needs review A pull request ready to be reviewed label Nov 22, 2019
@BogdanDor@angryermine
Apply suggestions from code review
49904f9
Co-Authored-By: Leonid Fedorov <lfedorov@live.com>
gcor
gcor reviewed Jan 10, 2020
View reviewed changes

@gcorgcor left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо большое за перевод! 👍
Несколько комментариев:

Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/nav.yml Outdated
@BogdanDor@gcor
Apply suggestions from code review
8f04463
Co-Authored-By: Anton Ahatov <anton@gcor.ru>
@BogdanDor

BogdanDor commented Jan 10, 2020

Copy link
Copy Markdown
ContributorAuthor

Во время компиляции markdown в html кавычки поменяются автоматически.

@ntishkevich

ntishkevich commented Jan 12, 2020

Copy link
Copy Markdown
Contributor

Во время компиляции markdown в html кавычки поменяются автоматически.

При наличии соответсвующего плагина в gatsby, с которым, кстати, имеются некоторы проблемы при наличии нескольких подряд идущих символов, поэтому, пожалуйста, поменяйте вездена кавычки-ёлочки, чтобы весь markdown файлы имели были в одном виде на случай, если плагин придется отключить. Спасибо.

@gcor

gcor commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

@lex111, @ntishkevich получится поревьюить?

lex111
lex111 suggested changes Feb 6, 2020
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BogdanDor спасибо за перевод, перед тем, как принять пулреквест, можете, пожалуйста, принять предложенные изменения?

Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
Comment threadcontent/docs/implementation-notes.md Outdated
BogdanDorand others added 2 commits February 7, 2020 17:02
@BogdanDor@lex111@gcor
Apply suggestions from code review
1fa3699
Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
Co-Authored-By: Anton Ahatov <anton@gcor.ru>
@BogdanDor
Apply and update suggestions from code review
e2f7c9d
@BogdanDor
BogdanDor requested a review from lex111February 7, 2020 14:23
lex111
lex111 approved these changes Feb 9, 2020
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcor посмотри ещё раз и сливай этот PR.

@gcor
gcor merged commit 395465a into reactjs:masterFeb 10, 2020
@BogdanDor
BogdanDor deleted the implementation-notes-translate branch August 27, 2020 11:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@angryermineangryermineangryermine left review comments
@gcorgcorgcor left review comments
@lex111lex111lex111 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs reviewA pull request ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BogdanDor@ntishkevich@gcor@angryermine@lex111