Skip to content

"Suspense for data fetching" page translation - #446

Merged
gcor merged 14 commits into
reactjs:masterfrom
shdq:suspense-translation
Feb 11, 2020
Merged

"Suspense for data fetching" page translation#446
gcor merged 14 commits into
reactjs:masterfrom
shdq:suspense-translation

Conversation

@shdq

@shdqshdq commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

Перевод страницы Suspense for data fetching.

@shdqshdq mentioned this pull request Dec 12, 2019
Closed
5 tasks
@netlify

netlifyBot commented Dec 12, 2019•
edited
Loading

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit f3de6bd

https://deploy-preview-446--ru-reactjs.netlify.com

@ntishkevich

ntishkevich commented Dec 16, 2019

Copy link
Copy Markdown
Contributor

Если все изменения готовы, то убирете, пожалуйста, из названия ПР-а WIP. Не понятно приступать к ревью или еще будут вноситься существенные изменения.

@shdq

shdq commented Dec 16, 2019

Copy link
Copy Markdown
ContributorAuthor

@ntishkevich хочу вычитать еще раз в превью, внесу правки если будут, уберу WIP и напишу, что готово к ревью. Спасибо.

@shdqshdq changed the title [WIP] "Suspense for data fetching" page translation"Suspense for data fetching" page translationDec 16, 2019
@shdq

shdq commented Dec 16, 2019

Copy link
Copy Markdown
ContributorAuthor

@ntishkevich готово к ревью

@ntishkevichntishkevich added the needs review A pull request ready to be reviewed label Dec 16, 2019
gcor
gcor reviewed Jan 10, 2020
View reviewed changes

@gcorgcor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Большая работа. Спасибо за перевод! 🔥

Несколько улучшений:

Comment threadcontent/docs/concurrent-mode-suspense.md
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
@shdq

shdq commented Jan 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Я перевел заголовок следующей страницы как Паттерны Конкурентных Пользовательских Интерфейсов, но лучше нам вместе это согласовать с @SmolinPavel, который занимается переводом этой страницы.

@gcor

gcor commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

У вас конфликт в ветке, получится решить?

@shdq

shdq commented Feb 7, 2020

Copy link
Copy Markdown
ContributorAuthor

@gcor поправил

lex111
lex111 suggested changes Feb 7, 2020
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shdq спасибо за большой хороший перевод! Пожалуйста, внесите поправки, описанные ниже.

Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
@shdq
shdq requested a review from lex111February 7, 2020 10:00
lex111
lex111 approved these changes Feb 9, 2020
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcor принимай пулреквест, если всё ок.

gcor
gcor reviewed Feb 10, 2020
View reviewed changes
Comment threadcontent/docs/concurrent-mode-suspense.md Outdated
@shdq@gcor
Update content/docs/concurrent-mode-suspense.md
f3de6bd
Co-Authored-By: Anton Ahatov <anton@gcor.ru>
@gcor
gcor merged commit be050df into reactjs:masterFeb 11, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@gcorgcorgcor left review comments
@lex111lex111lex111 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs reviewA pull request ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shdq@ntishkevich@gcor@lex111