Skip to content

Translate "Conditional Rendering" into Russian - #60

Merged
another-guy merged 3 commits into
masterfrom
another-guy/conditional-rendering
Feb 11, 2019
Merged

Translate "Conditional Rendering" into Russian#60
another-guy merged 3 commits into
masterfrom
another-guy/conditional-rendering

Conversation

@another-guy

@another-guyanother-guy commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@another-guyanother-guy added the needs review A pull request ready to be reviewed label Feb 10, 2019
@tesseralistesseralis mentioned this pull request Feb 10, 2019
Closed
88 tasks
@another-guy
another-guyforce-pushed the another-guy/conditional-rendering branch from 1e38fb1 to e0ed28aCompareFebruary 10, 2019 08:53
gaearon
gaearon requested changes Feb 10, 2019
View reviewed changes

@gaearongaearon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно больше глаголов. Спасибо!

Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md
@gaearongaearon added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
@another-guy

another-guy commented Feb 10, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@gaearon поправки по твоим замечаниям внесены.

Я ознакомлен с рекоммендациями по переводу и теми рассказами про канцелярит, которыми ты поделился. Поверь, то, как написан перевод, уже опирается на советы. Просто даже во время самостоятельной вычитки перед PR эти "брёвна в своих глазах" практически не видны. Спасибо за терпение!

Учитывая, что твои замечания всегда по существу, немного расстраивает, что потрачено почти столько же твоего времени на ревью, сколько мог бы занять самостоятельный перевод.

P.S. Можно на "ты".

gaearon
gaearon approved these changes Feb 10, 2019
View reviewed changes

@gaearongaearon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мелочи остались, в целом хорошо. Ставлю апрув, но надо поправить перед мержем. Спасибо!

Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md Outdated
Comment threadcontent/docs/conditional-rendering.md
Comment threadcontent/docs/conditional-rendering.md
@another-guyanother-guy removed the work in progress Author opened the pull-request but it's still being worked on label Feb 11, 2019
@another-guy
another-guy merged commit 2e78ba6 into masterFeb 11, 2019
@another-guyanother-guy mentioned this pull request Feb 11, 2019
Merged
@another-guyanother-guy added the needs proofread A read-through is still needed to release the document label Feb 13, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearongaearongaearon approved these changes

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@another-guy@gaearon