Skip to content

JS environment-requirements - #68

Merged
lex111 merged 4 commits into
reactjs:masterfrom
kuhelbeher:js-environment-requirements
Feb 16, 2019
Merged

JS environment-requirements#68
lex111 merged 4 commits into
reactjs:masterfrom
kuhelbeher:js-environment-requirements

Conversation

@kuhelbeher

@kuhelbeherkuhelbeher commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@kuhelbeherkuhelbeher mentioned this pull request Feb 10, 2019
Closed
88 tasks
gaearon
gaearon requested changes Feb 10, 2019
View reviewed changes

@gaearongaearon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

мелочи

Comment threadcontent/docs/nav.yml Outdated
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
lex111
lex111 reviewed Feb 10, 2019
View reviewed changes
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
@lex111lex111 added the work in progress Author opened the pull-request but it's still being worked on label Feb 10, 2019
lex111
lex111 reviewed Feb 12, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Последние штрихи

Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
@kuhelbeher
kuhelbeherforce-pushed the js-environment-requirements branch from f2f1992 to ac8590cCompareFebruary 14, 2019 07:04
another-guy
another-guy suggested changes Feb 14, 2019
View reviewed changes
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
Comment threadcontent/docs/reference-javascript-environment-requirements.md Outdated
Comment threadcontent/docs/reference-javascript-environment-requirements.md
@lex111lex111 added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 15, 2019
@another-guy

another-guy commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

@kuhelbeher спасибо за перевод!

@another-guyanother-guy removed the needs review A pull request ready to be reviewed label Feb 16, 2019
@lex111
lex111 merged commit 661e75b into reactjs:masterFeb 16, 2019
@lex111

lex111 commented Feb 16, 2019

Copy link
Copy Markdown
Contributor

@kuhelbeher спасибо!

@kuhelbeher
kuhelbeher deleted the js-environment-requirements branch February 18, 2019 07:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearongaearongaearon requested changes
+3 more reviewers
@Michael-dykoMichael-dykoMichael-dyko left review comments
@lex111lex111lex111 approved these changes
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kuhelbeher@another-guy@lex111@gaearon@Michael-dyko