Skip to content

Installation translation - #842

Merged
ntishkevich merged 9 commits into
reactjs:mainfrom
Palidos:installation-translation
May 22, 2023
Merged

Installation translation#842
ntishkevich merged 9 commits into
reactjs:mainfrom
Palidos:installation-translation

Conversation

@Palidos

@PalidosPalidos commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Translation of Installation page

gcor
gcor reviewed Apr 26, 2023
View reviewed changes

@gcorgcor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо!

Comment threadsrc/content/learn/installation.md Outdated
Comment threadsrc/content/learn/installation.md Outdated
Comment threadsrc/content/learn/installation.md Outdated
Comment threadsrc/content/learn/installation.md Outdated
Comment threadsrc/content/learn/installation.md Outdated
ntishkevich
ntishkevich suggested changes Apr 26, 2023
View reviewed changes
Comment threadsrc/content/learn/installation.md
Comment threadsrc/content/learn/installation.md Outdated
@Palidos
Fix line break
a2ef011
Fix "Start a New React Project" translation
@titovmxtitovmx mentioned this pull request May 2, 2023
Merged
@titovmxtitovmx mentioned this pull request May 12, 2023
Open
ntishkevich
ntishkevich suggested changes May 18, 2023
View reviewed changes

@ntishkevichntishkevich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо за перевод. Небольшие комментарии.

Также хочу обратить внимание, что переводить файлы типа sideBar.json, MDXComponents.txs, ResetButton.tsx согласно описанию из ишью #843 нужно в последнюю очередь из всего списка для перевода.

Comment threadsrc/content/learn/installation.md Outdated
Comment threadsrc/content/learn/installation.md Outdated
Comment threadsrc/content/learn/installation.md Outdated
ntishkevich
ntishkevich approved these changes May 19, 2023
View reviewed changes

@ntishkevichntishkevich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fpetrakov
fpetrakov reviewed May 19, 2023
View reviewed changes

@fpetrakovfpetrakov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет, спасибо за перевод, есть предложения, что думаешь?

Comment threadsrc/content/learn/installation.md
Comment threadsrc/content/learn/installation.md Outdated
Comment threadsrc/content/learn/installation.md Outdated
Comment threadsrc/content/learn/installation.md Outdated
Comment threadsrc/content/learn/installation.md Outdated
Comment threadsrc/content/learn/installation.md Outdated
@Palidos
Palidos requested a review from gcorMay 19, 2023 18:17
gcor
gcor approved these changes May 21, 2023
View reviewed changes
Comment threadsrc/content/learn/installation.md Outdated
@Palidos@gcor
Add suggestion
765c9f6
Co-authored-by: Anton Ahatov <anton@gcor.ru>
@Palidos
Add suggestion
a0ee218
"для ознакомления с самыми важными концепциями"
@ntishkevich
ntishkevich merged commit 0fc905f into reactjs:mainMay 22, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@ntishkevichntishkevichntishkevich approved these changes
@fpetrakovfpetrakovfpetrakov left review comments
@gcorgcorgcor approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Palidos@gcor@ntishkevich@fpetrakov