Skip to content

Rules of Hooks translation - #86

Merged
lex111 merged 7 commits into
reactjs:masterfrom
airyboy:master
Feb 28, 2019
Merged

Rules of Hooks translation#86
lex111 merged 7 commits into
reactjs:masterfrom
airyboy:master

Conversation

@airyboy

@airyboyairyboy commented Feb 11, 2019

Copy link
Copy Markdown

No description provided.

@airyboyairyboy mentioned this pull request Feb 11, 2019
Closed
88 tasks
@another-guyanother-guy added the needs review A pull request ready to be reviewed label Feb 11, 2019
pavelkeyzik
pavelkeyzik reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/hooks-rules.md Outdated
@another-guyanother-guy mentioned this pull request Feb 12, 2019
Closed
lex111
lex111 reviewed Feb 12, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хороший старт, небольшое ревью

Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
angryermine
angryermine reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/hooks-rules.md Outdated
@another-guyanother-guy added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 12, 2019
@another-guyanother-guy self-assigned this Feb 16, 2019
another-guy
another-guy reviewed Feb 20, 2019
View reviewed changes
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
Comment threadcontent/docs/hooks-rules.md Outdated
@another-guy

another-guy commented Feb 20, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@airyboy good job! Немного замечаний по стилю и консистентности с другими переводами. До аппрува -- рукой подать. Спасибо!

@another-guyanother-guy removed their assignment Feb 20, 2019
ntishkevich
ntishkevich reviewed Feb 24, 2019
View reviewed changes
Comment threadcontent/docs/hooks-rules.md Outdated
lex111
lex111 approved these changes Feb 28, 2019
View reviewed changes

@lex111lex111 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зафиксировал предложенные изменения от @another-guy и @ntishkevich + добавил кое-что своё.

@lex111
lex111 merged commit ea20319 into reactjs:masterFeb 28, 2019
@lex111

lex111 commented Feb 28, 2019

Copy link
Copy Markdown
Contributor

Спасибо @airyboy за перевод, а также @pavelkeyzik, @lfedorov, @another-guy и @ntishkevich за ревью! 🎉

Все прочие улучшения/доработки в отдельных PR.

@lex111lex111 added needs proofread A read-through is still needed to release the document and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 28, 2019
@netlify

netlifyBot commented Feb 28, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 085e5c6

https://deploy-preview-86--ru-reactjs.netlify.com

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearongaearongaearon left review comments
+5 more reviewers
@angryermineangryermineangryermine left review comments
@another-guyanother-guyanother-guy left review comments
@ntishkevichntishkevichntishkevich left review comments
@pavelkeyzikpavelkeyzikpavelkeyzik left review comments
@lex111lex111lex111 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@airyboy@another-guy@lex111@gaearon@angryermine@ntishkevich@pavelkeyzik