Skip to content

Translation for "Responding to Events" - #861

Closed
xxtereshko wants to merge 14 commits into
reactjs:mainfrom
xxtereshko:feat/learn-event-handling
Closed

Translation for "Responding to Events"#861
xxtereshko wants to merge 14 commits into
reactjs:mainfrom
xxtereshko:feat/learn-event-handling

Conversation

@xxtereshko

@xxtereshkoxxtereshko commented Apr 29, 2023

Copy link
Copy Markdown
Contributor

"Responding to Events" page translation (src/content/learn/responding-to-events.md)

@xxtereshkoxxtereshko mentioned this pull request Apr 29, 2023
Open
fpetrakov
fpetrakov reviewed Apr 29, 2023
View reviewed changes

@fpetrakovfpetrakov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет, спасибо за перевод, немного посмотрел, есть предложения, что думаешь?

Comment threadsrc/content/learn/responding-to-events.md Outdated
Comment threadsrc/content/learn/responding-to-events.md Outdated
Comment threadsrc/content/learn/responding-to-events.md Outdated
Comment threadsrc/content/learn/responding-to-events.md Outdated
Comment threadsrc/content/learn/responding-to-events.md Outdated
Comment threadsrc/content/learn/responding-to-events.md Outdated
Comment threadsrc/content/learn/responding-to-events.md Outdated
xxtereshkoand others added 5 commits April 29, 2023 16:07
@xxtereshko@fpetrakov
Update src/content/learn/responding-to-events.md
ad30b2d
Co-authored-by: Fedya Petrakov <jakephin2015@gmail.com>
@xxtereshko@fpetrakov
Update src/content/learn/responding-to-events.md
2419ae0
Co-authored-by: Fedya Petrakov <jakephin2015@gmail.com>
@xxtereshko@fpetrakov
Update src/content/learn/responding-to-events.md
7ab42f3
Co-authored-by: Fedya Petrakov <jakephin2015@gmail.com>
@xxtereshko@fpetrakov
Update src/content/learn/responding-to-events.md
4c2a471
Co-authored-by: Fedya Petrakov <jakephin2015@gmail.com>
@xxtereshko@fpetrakov
Update src/content/learn/responding-to-events.md
3ad9660
Co-authored-by: Fedya Petrakov <jakephin2015@gmail.com>
@xxtereshko@fpetrakov
Update src/content/learn/responding-to-events.md
835eedb
Co-authored-by: Fedya Petrakov <jakephin2015@gmail.com>
@xxtereshko

xxtereshko commented Apr 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Привет, спасибо за перевод, немного посмотрел, есть предложения, что думаешь?

Привет, согласен со всем. А по кнопке - оставим "я ничего не делаю", как считаешь?

@fpetrakov

fpetrakov commented Apr 30, 2023

Copy link
Copy Markdown
Contributor

Давай :)

@xxtereshko@fpetrakov
Update src/content/learn/responding-to-events.md
8ee6769
Co-authored-by: Fedya Petrakov <jakephin2015@gmail.com>
gcor
gcor reviewed Jul 5, 2023
View reviewed changes
Comment threadsrc/content/learn/responding-to-events.md
- `UploadButton` passes `() => alert('Uploading!')` as the `onClick` prop to the `Button` inside.

Finally, your `Button` component accepts a prop called `onClick`. It passes that prop directly to the built-in browser `<button>` with `onClick={onClick}`. This tells React to call the passed function on click.
- `PlayButton` передает `handlePlayClick` в качестве пропа `onClick` внутренней кнопке.

@gcorgcorJul 5, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

пожалуйста проверьте чтобы были одинаковые переносы строк.
В будущем будут приходить правки, которые нужно будет ребейзить

@xxtereshkoxxtereshko closed this by deleting the head repository Apr 21, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@gcorgcorgcor left review comments
@fpetrakovfpetrakovfpetrakov left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xxtereshko@fpetrakov@gcor