Skip to content

Translate "Handling events" - #89

Merged
another-guy merged 7 commits into
reactjs:masterfrom
dpatrikeev:translation-basics-handling-events
Feb 21, 2019
Merged

Translate "Handling events"#89
another-guy merged 7 commits into
reactjs:masterfrom
dpatrikeev:translation-basics-handling-events

Conversation

@dpatrikeev

@dpatrikeevdpatrikeev commented Feb 11, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@tesseralistesseralis mentioned this pull request Feb 11, 2019
Closed
88 tasks
@another-guyanother-guy added the needs review A pull request ready to be reviewed label Feb 11, 2019
pavelkeyzik
pavelkeyzik reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/handling-events.md Outdated
pavelkeyzik
pavelkeyzik reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/handling-events.md Outdated
lex111
lex111 reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/handling-events.md Outdated
lex111
lex111 reviewed Feb 11, 2019
View reviewed changes
Comment threadcontent/docs/handling-events.md Outdated
another-guy
another-guy reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/handling-events.md Outdated
Comment threadcontent/docs/handling-events.md Outdated
Comment threadcontent/docs/handling-events.md Outdated
Comment threadcontent/docs/handling-events.md Outdated
Comment threadcontent/docs/handling-events.md
Comment threadcontent/docs/handling-events.md
Comment threadcontent/docs/handling-events.md Outdated
Comment threadcontent/docs/handling-events.md Outdated
Comment threadcontent/docs/handling-events.md
Michael-dyko
Michael-dyko reviewed Feb 12, 2019
View reviewed changes
Comment threadcontent/docs/handling-events.md Outdated
@another-guyanother-guy added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 12, 2019
@dpatrikeev

dpatrikeev commented Feb 13, 2019

Copy link
Copy Markdown
ContributorAuthor

Большое спасибо за обратную связь! Внесу изменения вечером.

@dpatrikeev

dpatrikeev commented Feb 15, 2019

Copy link
Copy Markdown
ContributorAuthor

@another-guy посмотри, пожалуйста.

@another-guy

another-guy commented Feb 16, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@dpatrikeev в течение 12 часов сделаю. Извини за задержку, успеваю только 3-5 толковых ревью сделать за вечер...

@another-guyanother-guy self-assigned this Feb 16, 2019
another-guy
another-guy suggested changes Feb 17, 2019
View reviewed changes
Comment threadcontent/docs/handling-events.md
Comment threadcontent/docs/handling-events.md Outdated
Comment threadcontent/docs/handling-events.md Outdated
Comment threadcontent/docs/handling-events.md Outdated
Comment threadcontent/docs/handling-events.md Outdated
Comment threadcontent/docs/handling-events.md Outdated
[**Посмотреть на CodePen**](http://codepen.io/gaearon/pen/xEmzGg?editors=0010)

You have to be careful about the meaning of `this` in JSX callbacks. In JavaScript, class methods are not [bound](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_objects/Function/bind) by default. If you forget to bind `this.handleClick` and pass it to `onClick`, `this` will be `undefined` when the function is actually called.
Будьте внимательны со значением `this` в JSX-колбэках. В JavaScript методы класса не [привязаны](https://developer.mozilla.org/ru/docs/Web/JavaScript/Reference/Global_Objects/Function/bind) по умолчанию. Если вы забудете привязать метод `this.handleClick` и передать его в `onClick`, `this` будет `undefined` при фактическом вызове функции.

@another-guyanother-guyFeb 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Будьте внимательны со значением `this` в JSX-колбэках. В JavaScript методы класса не [привязаны](https://developer.mozilla.org/ru/docs/Web/JavaScript/Reference/Global_Objects/Function/bind) по умолчанию. Если вы забудете привязать метод `this.handleClick` и передать его в `onClick`, `this` будет `undefined`при фактическом вызове функции.
Будьте внимательны со значением `this` в JSX-колбэках. В JavaScript методы класса не [привязаны](https://developer.mozilla.org/ru/docs/Web/JavaScript/Reference/Global_Objects/Function/bind) по умолчанию. Если вы забудете привязать метод `this.handleClick` и передать его в `onClick`, `this` будет `undefined`на момент вызова функции.

@another-guyanother-guyFeb 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Так будет чуть яснее?

@dpatrikeevdpatrikeevFeb 18, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне коллега предложил еще один вариант:
При обращении к this в JSX-колбэках необходимо учитывать, что методы класса в JavaScript по умолчанию не привязаны к контексту. Если вы забудете привязать метод this.handleClick и передать его в onClick, значение this будет undefined в момент вызова функции.

@another-guy, что думаете?

@lex111lex111Feb 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хороший вариант, мне нравится, не знаю, как @another-guy

@another-guyanother-guyFeb 20, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, так очень хорошо!

Comment threadcontent/docs/handling-events.md Outdated
lex111
lex111 reviewed Feb 18, 2019
View reviewed changes
Comment threadcontent/docs/handling-events.md Outdated
```

Here, `e` is a synthetic event. React defines these synthetic events according to the [W3C spec](https://www.w3.org/TR/DOM-Level-3-Events/), so you don't need to worry about cross-browser compatibility. See the [`SyntheticEvent`](/docs/events.html) reference guide to learn more.
Здесь `e` — это синтетическое событие. React определяет синтетические события в соответствии со [спецификацией W3C](https://www.w3.org/TR/DOM-Level-3-Events/), поэтому не волнуйтесь о кроссбраузерности. Посмотрите [руководство о `SyntheticEvent`](/docs/events.html), чтобы узнать о них больше.

@lex111lex111Feb 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А если конкретизируем, а то ещё короткое предложение получается?

Suggested change
Здесь`e` — это синтетическое событие. React определяет синтетические события в соответствии со [спецификацией W3C](https://www.w3.org/TR/DOM-Level-3-Events/), поэтому не волнуйтесь о кроссбраузерности. Посмотрите [руководство о `SyntheticEvent`](/docs/events.html), чтобы узнать о них больше.
В приведённом выше коде`e` — это синтетическое событие. React определяет синтетические события в соответствии со [спецификацией W3C](https://www.w3.org/TR/DOM-Level-3-Events/), поэтому не волнуйтесь о кроссбраузерности. Посмотрите [руководство о `SyntheticEvent`](/docs/events.html), чтобы узнать о них больше.

@another-guy

another-guy commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

@lex111 Аппрув!

@dpatrikeev Надо только исправить два комментария оставшихся... Хорошая работа!

@another-guyanother-guy removed their assignment Feb 20, 2019
@netlify

netlifyBot commented Feb 21, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit dd48eb5

https://deploy-preview-89--ru-reactjs.netlify.com

@another-guy
another-guy merged commit d837c2c into reactjs:masterFeb 21, 2019
@another-guyanother-guy added needs proofread A read-through is still needed to release the document and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@lex111lex111lex111 approved these changes
@pavelkeyzikpavelkeyzikpavelkeyzik left review comments
@Michael-dykoMichael-dykoMichael-dyko left review comments
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dpatrikeev@another-guy@lex111@pavelkeyzik@Michael-dyko