Skip to content

Translation FAQ File Structure (faq-structure.md) - #98

Merged
another-guy merged 7 commits into
reactjs:masterfrom
RinatRezyapov:faq-structure
Feb 21, 2019
Merged

Translation FAQ File Structure (faq-structure.md)#98
another-guy merged 7 commits into
reactjs:masterfrom
RinatRezyapov:faq-structure

Conversation

@RinatRezyapov

@RinatRezyapovRinatRezyapov commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

Не уверен как лучше перевести routes, да и вообще нужен ли он если далее про него ни слова.

Grouping by features or routes
Группировка по функционалу или маршруту

Не нашел информации по этому принципу на русском, нужно ли переводить или сделать транслитерацию?

This principle is called "colocation".
Этот принцип называется «совместное размещение».

@another-guy

another-guy commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

Мне нравится совместное размещение.

@another-guyanother-guy added the needs review A pull request ready to be reviewed label Feb 12, 2019
@tesseralistesseralis mentioned this pull request Feb 12, 2019
Closed
88 tasks
angryermine
angryermine reviewed Feb 12, 2019
View reviewed changes

@angryermineangryermine left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Небольшие исправления

Comment threadcontent/docs/faq-structure.md Outdated
Comment threadcontent/docs/faq-structure.md Outdated
lex111
lex111 reviewed Feb 13, 2019
View reviewed changes
Comment threadcontent/docs/faq-structure.md Outdated
Comment threadcontent/docs/faq-structure.md Outdated
Comment threadcontent/docs/faq-structure.md Outdated
Comment threadcontent/docs/faq-structure.md Outdated
Comment threadcontent/docs/faq-structure.md Outdated
@RinatRezyapov

RinatRezyapov commented Feb 13, 2019

Copy link
Copy Markdown
ContributorAuthor

Спасибо за исправления. Поправил.

angryermine
angryermine reviewed Feb 13, 2019
View reviewed changes
Comment threadcontent/docs/faq-structure.md Outdated
@lex111lex111 added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 13, 2019
lex111
lex111 reviewed Feb 14, 2019
View reviewed changes
Comment threadcontent/docs/faq-structure.md Outdated
lex111
lex111 reviewed Feb 14, 2019
View reviewed changes
Comment threadcontent/docs/faq-structure.md Outdated
@lex111lex111 added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 16, 2019
gcor
gcor reviewed Feb 17, 2019
View reviewed changes
Comment threadcontent/docs/faq-structure.md Outdated
Comment threadcontent/docs/faq-structure.md Outdated
Comment threadcontent/docs/faq-structure.md Outdated
Comment threadcontent/docs/faq-structure.md Outdated
Comment threadcontent/docs/faq-structure.md Outdated
Comment threadcontent/docs/faq-structure.md Outdated
another-guy
another-guy reviewed Feb 20, 2019
View reviewed changes
Comment threadcontent/docs/faq-structure.md Outdated
@another-guy

another-guy commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

Блестящий перевод! 🎉

Одну вещь только надо решить, мне кажется.

@another-guyanother-guy removed their assignment Feb 20, 2019
another-guy
another-guy reviewed Feb 20, 2019
View reviewed changes
Comment threadcontent/docs/faq-structure.md Outdated
#### Группировка по возможностям или маршрутам {#grouping-by-features-or-routes}

One common way to structure projects is locate CSS, JS, and tests together inside folders grouped by feature or route.
Один из популярных подходов -- это размещение файлов CSS, JS и тестов в папках, сгруппированных по возможности или маршруту.

@another-guyanother-guyFeb 20, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Один из популярных подходов -- это размещение файлов CSS, JS и тестов в папках, сгруппированных по возможности или маршруту.
Один из популярных подходов -- это размещение файлов CSS, JS и тестов в папках, сгруппированных по функциональности или маршруту.

another-guy
another-guy reviewed Feb 20, 2019
View reviewed changes
Comment threadcontent/docs/faq-structure.md Outdated
@another-guyanother-guy mentioned this pull request Feb 20, 2019
Merged
@netlify

netlifyBot commented Feb 21, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 526a45e

https://deploy-preview-98--ru-reactjs.netlify.com

@another-guy
another-guy merged commit 68f38aa into reactjs:masterFeb 21, 2019
@another-guyanother-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Feb 22, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@angryermineangryermineangryermine left review comments
@lex111lex111lex111 approved these changes
@gcorgcorgcor left review comments
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RinatRezyapov@another-guy@angryermine@lex111@gcor