Skip to content

Translate Uncontrolled Components - #37

Merged
lex111 merged 7 commits into
masterfrom
uncontrolled-components
Feb 28, 2019
Merged

Translate Uncontrolled Components#37
lex111 merged 7 commits into
masterfrom
uncontrolled-components

Conversation

@lex111

@lex111lex111 commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

Перевод взят из Crowdin без изменений — https://crowdin.com/translate/react/2090/en-ru

@lex111lex111 added work in progress Author opened the pull-request but it's still being worked on from-crowdin This translation came from Crowdin labels Feb 9, 2019
@tesseralistesseralis mentioned this pull request Feb 9, 2019
Closed
88 tasks
gaearon
gaearon reviewed Feb 10, 2019
View reviewed changes
Comment threadcontent/docs/uncontrolled-components.md Outdated
@lex111lex111 added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 10, 2019
@lex111

lex111 commented Feb 10, 2019

Copy link
Copy Markdown
ContributorAuthor

@gaearon посмотри, пожалуйста.

gaearon
gaearon requested changes Feb 10, 2019
View reviewed changes

@gaearongaearon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо поработать над понятностью. Мне кажется, смысл ускользает.

Comment threadcontent/docs/uncontrolled-components.md Outdated
Comment threadcontent/docs/uncontrolled-components.md Outdated
Comment threadcontent/docs/uncontrolled-components.md Outdated
Comment threadcontent/docs/uncontrolled-components.md Outdated
Comment threadcontent/docs/uncontrolled-components.md Outdated
Comment threadcontent/docs/uncontrolled-components.md Outdated
another-guy
another-guy reviewed Feb 14, 2019
View reviewed changes
Comment threadcontent/docs/uncontrolled-components.md Outdated
@another-guyanother-guy self-assigned this Feb 14, 2019
another-guy
another-guy suggested changes Feb 15, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lex111 извини, только сейчас смог внимательно прочитать перевод.

Comment threadcontent/docs/uncontrolled-components.md Outdated
Comment threadcontent/docs/uncontrolled-components.md Outdated
Comment threadcontent/docs/uncontrolled-components.md Outdated
Comment threadcontent/docs/uncontrolled-components.md Outdated
Comment threadcontent/docs/uncontrolled-components.md Outdated
Comment threadcontent/docs/uncontrolled-components.md Outdated
@another-guyanother-guy removed their assignment Feb 15, 2019
@another-guy@lex111
Apply suggestions from code review by@another-guy
33936d5
Co-Authored-By: lex111 <lex61rus@gmail.com>
@HeegiinyHeegiiny mentioned this pull request Feb 21, 2019
Merged
@another-guyanother-guy self-assigned this Feb 22, 2019
@thechch

thechch commented Feb 23, 2019

Copy link
Copy Markdown
Contributor

Я использовал "управляемые"/"неуправляемые" компоненты, в этом переводе "контролируемые"/"неконтролируемые". Необходимо придти к какому то единому варианту перевода.

@another-guy

another-guy commented Feb 23, 2019

Copy link
Copy Markdown
Contributor

@thechch в нашем словаре вот так указано:

(un)controlled component -- (не)контролируемый компонент

@thechch

thechch commented Feb 24, 2019

Copy link
Copy Markdown
Contributor

@another-guy понял + принял

@another-guyanother-guy removed their assignment Feb 28, 2019
@another-guyanother-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed under discussion labels Feb 28, 2019
another-guy
another-guy approved these changes Feb 28, 2019
View reviewed changes

@another-guyanother-guy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lex111 спасибо за работу и за терпение! 💯

@netlify

netlifyBot commented Feb 28, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit a89d748

https://deploy-preview-37--ru-reactjs.netlify.com

@another-guy

another-guy commented Feb 28, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

А ещё подумал, а почему и правда контролируемые, а не управляемые? По-моему последний попроще и "по-русски" звучит, что думаешь? cc @another-guy

@lex111
По-идее, да. "управляемые" это русское слово, а "контролируемые" -- заимствованное. Но у нас в словаре уже есть правило. Поэтому я завёл бы issue на вычитку после того, как общий перевод будет готов. Лучше быть консистетными сейчас.

@lex111

lex111 commented Feb 28, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Поэтому я завёл бы issue на вычитку после того, как общий перевод будет готов. Лучше быть консистетными сейчас

👍 (создал ишью #202 )

@lex111
lex111 merged commit 89b870f into masterFeb 28, 2019
@lex111
lex111 deleted the uncontrolled-components branch February 28, 2019 03:46
@netlify

netlifyBot commented Feb 28, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 16ee9ea

https://deploy-preview-37--ru-reactjs.netlify.com

@lex111lex111 mentioned this pull request Feb 28, 2019
Closed
@netlify

netlifyBot commented Feb 28, 2019

Copy link
Copy Markdown

Deploy preview for ru-reactjs ready!

Built with commit 541b699

https://deploy-preview-37--ru-reactjs.netlify.com

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaearongaearongaearon requested changes
+2 more reviewers
@thechchthechchthechch left review comments
@another-guyanother-guyanother-guy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

from-crowdinThis translation came from Crowdinneeds proofreadA read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lex111@thechch@another-guy@gaearon