Skip to content

Translate <option> option - full - #435

Merged
alioguzhan merged 10 commits into
reactjs:mainfrom
K2adir:main
May 9, 2023
Merged

Translate <option> option - full #435
alioguzhan merged 10 commits into
reactjs:mainfrom
K2adir:main

Conversation

@K2adir

@K2adirK2adir commented May 6, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actionsBot commented May 6, 2023•
edited
Loading

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@K2adirK2adir changed the title Option translated - Option translate -May 6, 2023
@K2adirK2adir changed the title Option translate -Translate <option> - full May 6, 2023
@K2adirK2adir changed the title Translate <option> - full Translate <option> option - full May 6, 2023
@alioguzhan

alioguzhan commented May 6, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Preview deploymenti basarisiz olmus. Bir yerde bir hata olabilir. Localde sitenin calisip calismadigini kontrol edebilir misiniz bu branchta ? Tesekkurler.

Sonrasinda review a baslarim.

@K2adir
fix - backtick error - tested OK
6f54c80
Line 36, had a backtick problem,
this section " React, `<><AltEleman /></>`'dan `[<AltEleman />]`'a "
this commit fixes this.
tested on browser.
@K2adir
fix backticks - add missing ``
35d8150
missing backticks added line 27
@K2adir

K2adir commented May 7, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

fragment.md file had an issue with an extra backtick, fixing that, resolved the problem with the option.md file.
tested on the browser, double-checked with the English doc. All tests passed.

@alioguzhan good to go

alioguzhan
alioguzhan requested changes May 7, 2023
View reviewed changes

@alioguzhanalioguzhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tesekkurler. Bir iki nokta var sadece. sonrasinde merge edebiliriz.

Comment threadsrc/content/reference/react-dom/components/option.md Outdated
Comment threadsrc/content/reference/react-dom/components/option.md Outdated
@K2adir
K2adir requested a review from alioguzhanMay 8, 2023 04:07
alioguzhan
alioguzhan approved these changes May 9, 2023
View reviewed changes

@alioguzhanalioguzhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tesekkurler!

@alioguzhan
alioguzhan merged commit 4f443f0 into reactjs:mainMay 9, 2023
@alioguzhanalioguzhan mentioned this pull request May 9, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alioguzhanalioguzhanalioguzhan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@K2adir@alioguzhan