Skip to content

Add translation for "Importing and Exporting Components" page - #464

Merged
bkatsevych merged 3 commits into
reactjs:mainfrom
vadym-oliinyk:translation-importing-and-exporting-components
May 25, 2023
Merged

Add translation for "Importing and Exporting Components" page#464
bkatsevych merged 3 commits into
reactjs:mainfrom
vadym-oliinyk:translation-importing-and-exporting-components

Conversation

@vadym-oliinyk

@vadym-oliinykvadym-oliinyk commented May 11, 2023

Copy link
Copy Markdown
Contributor

No description provided.

vadym-oliinyk
vadym-oliinyk commented May 11, 2023
View reviewed changes
Comment threadsrc/content/learn/importing-and-exporting-components.md
Перенесіть компонент `Profile` у окремий файл `Profile.js`, а потім змініть компонент `App` так, щоб він рендерив `<Profile />` та `<Gallery />` один за іншим.

Move the `Profile` component to its own `Profile.js`, and then change the `App` component to render both `<Profile />` and `<Gallery />` one after another.
Ви можете використовувати як дефолтний, так і іменований експорт для `Profile`, проте переконайтеся, що використовуєте відповідний синтаксис імпорту як в `App.js`, так і в `Gallery.js`! Ви можете скористатися таблицею з розділу про поглиблений аналіз вище:

@vadym-oliinykvadym-oliinykMay 11, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут "deep dive" переклав як "поглиблений аналіз". Але не впевнений, що це доречно для цього глобального компоненту

vadym-oliinyk
vadym-oliinyk commented May 11, 2023
View reviewed changes
Comment threadsrc/content/learn/importing-and-exporting-components.md
* How to split components into multiple files
* Що таке файл кореневого компонента
* Як імпортувати та експортувати компонент
* Коли використовувати дефолтні та іменовані імпорти та експорти

@vadym-oliinykvadym-oliinykMay 11, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По всьому тексту переклав "default exports" як "дефолтні експорти", а не "експорти за замовчуванням". Чи це окей?

@vadym-oliinykvadym-oliinyk mentioned this pull request May 11, 2023
Open
bkatsevych
bkatsevych reviewed May 24, 2023
View reviewed changes
Comment threadsrc/content/learn/importing-and-exporting-components.md Outdated
bkatsevych
bkatsevych reviewed May 24, 2023
View reviewed changes
Comment threadsrc/content/learn/importing-and-exporting-components.md Outdated
bkatsevych
bkatsevych reviewed May 24, 2023
View reviewed changes
Comment threadsrc/content/learn/importing-and-exporting-components.md Outdated
bkatsevych
bkatsevych reviewed May 24, 2023
View reviewed changes
Comment threadsrc/content/learn/importing-and-exporting-components.md Outdated
bkatsevych
bkatsevych reviewed May 24, 2023
View reviewed changes
Comment threadsrc/content/learn/importing-and-exporting-components.md Outdated
bkatsevych
bkatsevych reviewed May 24, 2023
View reviewed changes
Comment threadsrc/content/learn/importing-and-exporting-components.md Outdated
bkatsevych
bkatsevych reviewed May 24, 2023
View reviewed changes
Comment threadsrc/content/learn/importing-and-exporting-components.md Outdated
bkatsevych
bkatsevych reviewed May 24, 2023
View reviewed changes
Comment threadsrc/content/learn/importing-and-exporting-components.md Outdated
bkatsevych
bkatsevych reviewed May 24, 2023
View reviewed changes
Comment threadsrc/content/learn/importing-and-exporting-components.md Outdated
bkatsevych
bkatsevych reviewed May 24, 2023
View reviewed changes
Comment threadsrc/content/learn/importing-and-exporting-components.md Outdated
@bkatsevych

bkatsevych commented May 25, 2023

Copy link
Copy Markdown
Collaborator

Гарна робота!

@github-actions

github-actionsBot commented May 25, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@bkatsevych
bkatsevych merged commit a4948ae into reactjs:mainMay 25, 2023
@vadym-oliinyk

vadym-oliinyk commented May 25, 2023

Copy link
Copy Markdown
ContributorAuthor

@bkatsevych дякую! внести ті корективи, що в коментарях вище? чи вони вже resolved бо не актуальні?)

@bkatsevych

bkatsevych commented May 25, 2023

Copy link
Copy Markdown
Collaborator

@vadym-oliinyk Після ревʼю, ваші + мої корективи вступають в силу, перед тим як замержити PR.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkatsevychbkatsevychbkatsevych approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vadym-oliinyk@bkatsevych