Skip to content

Translated "adding interactivity" page - #539

Closed
MinichMykyta wants to merge 0 commit into
reactjs:mainfrom
MinichMykyta:main
Closed

Translated "adding interactivity" page#539
MinichMykyta wants to merge 0 commit into
reactjs:mainfrom
MinichMykyta:main

Conversation

@MinichMykyta

@MinichMykytaMinichMykyta commented May 14, 2024•
edited by alinkedd
Loading

Copy link
Copy Markdown
Contributor

Blocked by Updating Objects in State translation

@vercel

vercelBot commented May 14, 2024•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
NameStatusPreviewCommentsUpdated (UTC)
uk-legacy-reactjs-org⬜️ Ignored (Inspect)Visit PreviewDec 29, 2024 4:56pm

@alinkeddalinkedd mentioned this pull request May 15, 2024
Open
@alinkedd
alinkedd self-requested a review May 15, 2024 09:44
@alinkedd
alinkedd marked this pull request as draft May 15, 2024 11:08
@alinkedd
alinkedd marked this pull request as draft May 15, 2024 11:08
@alinkedd
alinkedd marked this pull request as draft May 15, 2024 11:08
@alinkedd

alinkedd commented May 15, 2024

Copy link
Copy Markdown
Collaborator

Converted to draft based on this comment #457 (comment)

@alinkedd

alinkedd commented May 15, 2024

Copy link
Copy Markdown
Collaborator

Regarding the PR itself:

  1. Please, shorten the name to Translated "adding interactivity" page or similar.
  2. The Vercel deployment has failed. Usually it happens if page has invalid content that can’t be parsed. Please, run your fork locally as described in README and find out if that’s a case. I suggest to check this line as it’s possible for <button> without `` to be the root cause of failure, though I can’t check this myself right now.
    1. Also it’s just a good practice to run your work locally after translation

alinkedd
alinkedd requested changes May 15, 2024
View reviewed changes

@alinkeddalinkedd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я додала коментарі для частин, які не будуть змінюватися

Comment threadsrc/content/learn/adding-interactivity.md Outdated
Comment threadsrc/content/learn/adding-interactivity.md Outdated
Comment threadsrc/content/learn/adding-interactivity.md Outdated
Comment threadsrc/content/learn/adding-interactivity.md Outdated
<Toolbar
onPlayMovie={() => alert('Playing!')}
onUploadImage={() => alert('Uploading!')}
onPlayMovie={() => alert('Грає!')}

@alinkeddalinkeddMay 15, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Переклади прикладів мають співпадати із вже перекладеними розділами. Далі для інших місць треба буде перевірити, коли перекладуть інші частини

Comment threadsrc/content/learn/adding-interactivity.md Outdated
Comment threadsrc/content/learn/adding-interactivity.md Outdated
Comment threadsrc/content/learn/adding-interactivity.md Outdated
@MinichMykytaMinichMykyta changed the title Translated "adding interactivity" page on the React documentation website.Translated "adding interactivity" pageMay 19, 2024
alinkedd
alinkedd requested changes Dec 29, 2024
View reviewed changes
Comment threadsrc/content/learn/adding-interactivity.md Outdated
Comment threadsrc/content/learn/adding-interactivity.md Outdated
Comment threadsrc/content/learn/adding-interactivity.md Outdated
@alinkeddalinkedd closed this Mar 3, 2025
@alinkedd

alinkedd commented Mar 3, 2025

Copy link
Copy Markdown
Collaborator

Added in #595

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alinkeddalinkeddalinkedd requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MinichMykyta@alinkedd