Skip to content

Support Connector without DNS - #46

Merged
clue merged 5 commits into
reactphp-legacy:masterfrom
clue-labs:resolving
Nov 21, 2015
Merged

Support Connector without DNS#46
clue merged 5 commits into
reactphp-legacy:masterfrom
clue-labs:resolving

Conversation

@clue

@clueclue commented Sep 7, 2015

Copy link
Copy Markdown
Contributor
  • Split Connector into TcpConnector and DnsConnector
  • Legacy Connector now acts as a proxy for BC only

This PR builds on top of #43, so the diff also includes its changes. Look here for changes only related to this PR alone. (no longer applies after rebasing)

Fixes#12
Supersedes/closes#7

@clue

clue commented Sep 7, 2015

Copy link
Copy Markdown
ContributorAuthor

I consider this feature complete, though this is probably blocked until #43 is merged. As such, I've marked this WIP for now.

Any feedback is welcome! Perhaps this PR also helps to emphasize my motivation for the API used in #43/#45.

@clueclue added this to the v0.5 milestone Sep 22, 2015
@clue

clue commented Sep 23, 2015

Copy link
Copy Markdown
ContributorAuthor

I've just updated this PR so that it no longer includes a BC break.

@clueclue modified the milestones: v0.4.5, v0.5Sep 23, 2015
@clueclue changed the title [WIP] Support Connector without DNSSupport Connector without DNSSep 24, 2015
@clue

clue commented Sep 24, 2015

Copy link
Copy Markdown
ContributorAuthor

I've just rebased this on the current master now that #43 is in.

Ready for review :) Ping @WyriHaximus, @cboden

@WyriHaximus

WyriHaximus commented Sep 24, 2015 via email

Copy link
Copy Markdown
Contributor

@clue

clue commented Oct 13, 2015

Copy link
Copy Markdown
ContributorAuthor

I've just updated this PR so that it no longer includes a BC break.

This currently does not break compatibility what's been documented in our README, however the public interface of the Connector class had to be changed. Should we consider this a BC break, i.e. should this be v0.4.5 or v0.5.0?

@WyriHaximus

Copy link
Copy Markdown
Contributor

We might want to consider this a BC break as the publicly exposed API has changed. Also there are a ton of packages uses the class: http://packanalyst.com/class?q=React%5CSocketClient%5CConnector

@clue

clue commented Nov 18, 2015

Copy link
Copy Markdown
ContributorAuthor

We might want to consider this a BC break as the publicly exposed API has changed. Also there are a ton of packages uses the class:

For the reference, not a single one of the examples instantiating the Connector and calling its create() method is affected.

Only the two classes that extend the Connector and access its protected members would be affected.

I agree that we might want to play safe here and consider this a BC break nonetheless. The CHANGELOG should include some details that this doesn't affect most users though.

Also, I've just marked the internal APIs as such, so this doesn't happen again if we change the internal APIs.

:shipit: ? :)

@clueclue modified the milestones: v0.5, v0.4.5Nov 18, 2015
Comment threadsrc/TcpConnector.php Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: connection -> Connection

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting, fixed! :)

For the reference: This code has been like this ever since the very first commit in this repo.

@jsor

jsor commented Nov 20, 2015

Copy link
Copy Markdown
Contributor

A small typo, otherwise LGTM :shipit:

@WyriHaximus

Copy link
Copy Markdown
Contributor

LGTM :shipit:

clue added a commit that referenced this pull request Nov 21, 2015
@clue
clue merged commit 0460210 into reactphp-legacy:masterNov 21, 2015
@clue
clue deleted the resolving branch February 12, 2017 10:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Connector to have no Resolver

3 participants

@clue@WyriHaximus@jsor