Uh oh!
There was an error while loading. Please reload this page.
Support promise cancellation for coroutine() and clean up garbage references - #13
Merged
Merged
Conversation
SimonFrings
approved these changes
Nov 19, 2021
WyriHaximus
approved these changes
Nov 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds support for promise cancellation for the new
coroutine()function. You can now callcancel()on the resulting promise to cancel all pending promises within the coroutine. On top this, we now make sure to clean up any garbage references to not leak any memory.Builds on top of #9 and #12
Refs reactphp/socket#170 and others