Skip to content

[3.x] Template params can only have one argument - #74

Merged
clue merged 1 commit into
reactphp:3.xfrom
WyriHaximus-labs:3.x-template-params-can-only-have-one-argument
Jan 25, 2023
Merged

[3.x] Template params can only have one argument#74
clue merged 1 commit into
reactphp:3.xfrom
WyriHaximus-labs:3.x-template-params-can-only-have-one-argument

Conversation

@WyriHaximus

@WyriHaximusWyriHaximus commented Jan 25, 2023

Copy link
Copy Markdown
Member

The fact that a promise can also be rejected with a Throwable and/or Exception is implied and there is no need to also define that here.

Refs: reactphp/promise#223
Backports #73 from 4.x to 3.x

The fact that a promise can also be rejected with a Throwable and/or Exception is implied and there is no need to also define that here.
Refs: reactphp/promise#223
@WyriHaximusWyriHaximus added the bug Something isn't working label Jan 25, 2023
@WyriHaximusWyriHaximus added this to the v3.1.0 milestone Jan 25, 2023

@SimonFringsSimonFrings left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@clueclue added maintenance and removed bug Something isn't working labels Jan 25, 2023
@clue
clue merged commit 73ee629 into reactphp:3.xJan 25, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@WyriHaximus@clue@SimonFrings