Uh oh!
There was an error while loading. Please reload this page.
[4.x] Add PHPStan to test environment with max level - #76
Merged
Conversation
WyriHaximus
approved these changes
Jun 13, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
SimonFrings
approved these changes
Jun 14, 2023
This was referenced Jun 14, 2023
This was referenced Jun 23, 2023
This was referenced May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset adds PHPStan on
maxlevel to the test environment for all supported PHP versions. Unlike #64 runs the maximum level supported with all errors addressed without having to resort to a baseline. The changeset size seems reasonable and this does not other affect our public API, so this should be safe to apply.If this PR is merged, I will backport the changes from v4 to v3. The changes are almost identical across all versions, but only v4 takes advantage of fibers (#15).
Builds on top of clue/framework-x#200, clue/framework-x#201 and #66
See also https://github.com/orgs/reactphp/discussions/469 and #40