Uh oh!
There was an error while loading. Please reload this page.
[3.x] Update test suite to avoid unhandled promise rejections - #80
Merged
Merged
Conversation
clueforce-pushed
the
unhandled-rejections-v3
branch
from
July 7, 2023 09:19
4f37b1a to
0b30992Compareclue
commented
Jul 7, 2023
MemberAuthor
Updated now that reactphp/promise#248 has been merged, this is now ready for review This can be reproduced locally by installing Promise v3, which means either waiting for the official release scheduled next week or by installing the current development version with |
SimonFrings
approved these changes
Jul 7, 2023
WyriHaximus
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset backports #79 from
4.xto3.x. There is no need to backport to2.xas this only affects thecoroutine()function that is only available in v3+ (#12).Marking this as WIP until the upstream component has been released. In the meantime, this uses a temporary development branch.Builds on top of reactphp/promise#248, #77 and #47