Uh oh!
There was an error while loading. Please reload this page.
Forward compatibility with Stream v0.5 - #26
Merged
Conversation
jsor
approved these changes
Mar 8, 2017
clue
commented
Mar 8, 2017
MemberAuthor
Updated to include documentation about STDIO streams, so this now closes #17. |
jsor
requested changes
Mar 8, 2017
| and you can use any of its events and methods as usual: | ||
| ```php | ||
| $process->stdout->on('data', function ($chunk) { |
MemberAuthor
There was a problem hiding this comment.
I'd rather leave this like this in order to emphasize this is not necessarily a complete "data message", but could possibly be only a small "data chunk". This is also in line with all other stream documentations.
Any objections / recommendations?
Member
There was a problem hiding this comment.
I don't care, but you need to change the line below to echo $chunk; :)
Sorry, for not being clear enough.
MemberAuthor
There was a problem hiding this comment.
Duh, thanks for spotting, fixed and squashed 
jsor
approved these changes
Mar 9, 2017
This was referenced Mar 10, 2017
clue
commented
Mar 10, 2017
MemberAuthor
Rebased now that #27 is in |
WyriHaximus
approved these changes
Mar 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With some minimal changes, this component is in compatible with v0.4 and the new v0.5.